From: Yuan Fu <casouri@gmail.com>
To: Randy Taylor <dev@rjt.dev>
Cc: 59979@debbugs.gnu.org, me@eshelyaron.com
Subject: bug#59979: 30.0.50; dockerfile-ts-mode imenu issue
Date: Mon, 12 Dec 2022 14:59:19 -0800 [thread overview]
Message-ID: <A20C4274-24E2-46F1-BF0E-65AE4D3EF7CC@gmail.com> (raw)
In-Reply-To: <m1sfhl1xpv.fsf@esmac.lan>
Randy Taylor <dev@rjt.dev> writes:
> On Monday, December 12th, 2022 at 03:28, Eshel Yaron via "Bug reports
> for GNU Emacs, the Swiss army knife of text editors"
> <bug-gnu-emacs@gnu.org> wrote:
>>
>> Randy Taylor dev@rjt.dev writes:
>>
>> > On Sunday, December 11th, 2022 at 18:57, Randy Taylor dev@rjt.dev wrote:
>> >
>> > I didn't notice this because I use conult-imenu, which will add an
>> > index for any duplicates. imenu doesn't do this, and for other modes
>> > like c-mode, c++-mode, org-mode, etc., only the first entry gets
>> > shown.
>> >
>> > I've attached a patch which will use the stage name if it's available,
>> > otherwise use the base image.
>>
>>
>> Great :) That's certainly an improvement.
>>
>> I still maintain that using the base image as an identifier of the build
>> stage is not that useful, it doesn't really identify the stage in any
>> way, like identifying functions their arguments doesn't make a lot of
>> sense. I do see how in practice that'll probably be fine in most cases.
>>
>
> We don't get any information about which stage is which beyond the
> base image and potential alias (which is all Dockerfiles themselves
> have anyway), so we would need to track that stuff ourselves, and I
> don't think it's worth the complexity. Dockerfiles give us a solution
> to this anyway: use aliases.
>
> Perhaps consider trying a different imenu implementation? I use
> consult-imenu which gives indexes for any duplicates (it also flattens
> imenu which I really like). Maybe someone could add something like
> that to imenu.
>
> Can someone install the patch? Thanks.
Applied, thanks! I’ll leave closing the report to one of you guys :-)
Yuan
next prev parent reply other threads:[~2022-12-12 22:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 20:39 bug#59979: 30.0.50; dockerfile-ts-mode imenu issue Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-11 23:57 ` Randy Taylor
2022-12-12 2:30 ` Randy Taylor
2022-12-12 8:28 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-12 20:16 ` Randy Taylor
2022-12-12 22:59 ` Yuan Fu [this message]
2022-12-13 0:41 ` Randy Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A20C4274-24E2-46F1-BF0E-65AE4D3EF7CC@gmail.com \
--to=casouri@gmail.com \
--cc=59979@debbugs.gnu.org \
--cc=dev@rjt.dev \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.