From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59979: 30.0.50; dockerfile-ts-mode imenu issue Date: Mon, 12 Dec 2022 14:59:19 -0800 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39120"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59979@debbugs.gnu.org, me@eshelyaron.com To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 13 00:00:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4rmL-0009sb-V9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Dec 2022 00:00:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4rmG-0004zY-AG; Mon, 12 Dec 2022 18:00:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rmE-0004ym-Id for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 18:00:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4rmE-0000ol-7x for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 18:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4rmE-0005Wq-0X for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 18:00:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 23:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59979 X-GNU-PR-Package: emacs Original-Received: via spool by 59979-submit@debbugs.gnu.org id=B59979.167088596921207 (code B ref 59979); Mon, 12 Dec 2022 23:00:01 +0000 Original-Received: (at 59979) by debbugs.gnu.org; 12 Dec 2022 22:59:29 +0000 Original-Received: from localhost ([127.0.0.1]:56035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rlh-0005Vz-Fh for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:59:29 -0500 Original-Received: from mail-pl1-f181.google.com ([209.85.214.181]:46767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rlf-0005Vr-GG for 59979@debbugs.gnu.org; Mon, 12 Dec 2022 17:59:28 -0500 Original-Received: by mail-pl1-f181.google.com with SMTP id jn7so13642594plb.13 for <59979@debbugs.gnu.org>; Mon, 12 Dec 2022 14:59:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=D/6uINqlvriBivfnoW3Q+bX9z6tqI5SqlVhNX3TzEuo=; b=UjGOk2rso+vvrJbOSFDnu0WSxALyF7XMspoPUJbP3kTHwBeBzfiIzing6piBa9gjb9 b8oXY/S89lCK4YpvZuMFCUt9W0MPrl+4sqiP6BjDHvulUmY4LlWWOPbecLCsOh4sG14J vFCp2TiU5CvBugcW0rFnEb8x3jsrzoyNhCa6J9/JvaVQenFFTE3cTITM/y5s9wGp8+51 eve50mI9gQpZ5Q4K0g+bj0R0By95m9t465Hx0cr0HwnFoqTc459gwwPaXuMoJ2mroKNz QpgBOfh6IkorwydSf302gXzKRLlpdOv1CWuCVLodYfbdXfIOT/esG3JUtqeqwcq+zWfr spNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D/6uINqlvriBivfnoW3Q+bX9z6tqI5SqlVhNX3TzEuo=; b=TrQSHg8d/MuqV9hvGMLvk8++CQyngkbCtR82NMqqvKcEDQagTid1igzY33aVc47XFe ToYSj/ey04LbPrcjSmhCAxjnl84O+ZnM5KWYlK2lUHvY4yh2zXEuSyGX6xihenTOX0kc nRqEljSRcDwApw7MfYS4i75Cy4hxjJWX0+Bc/NxVn/5AzPgx6Fp2QSA3+6vTGuBlutWw EOsSb298H8cIanmUEi5FI8mdKtBlM9MUuV5o/VoMOpg+RkWOZx+UffZn7xuuJm4K37Yy 3pGy0zq63g2qn97Yutg7wP+Ess+j6ShQKo1ju0lYPTOCh51WvXrEQYBNcpyrK3VXrxN+ 8JbA== X-Gm-Message-State: ANoB5pmnZvSsyPmeBvxp9m64hX6nyOBygfs6jSFBeKzDuZ++y1jMxFbI gbOo3CkhibXi0AEfxvv5Qh+imItehHR5rw== X-Google-Smtp-Source: AA0mqf5lhSeIcL21CFKS/WSqZffNpgo1rbnFpB1cIJuwPgu7feVLpRe4HF3cWQ92qkk5wwkJF4Oxqw== X-Received: by 2002:a17:903:4cd:b0:189:c57c:9a19 with SMTP id jm13-20020a17090304cd00b00189c57c9a19mr16466659plb.58.1670885961785; Mon, 12 Dec 2022 14:59:21 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id k5-20020a170902c40500b001766a3b2a26sm6931963plk.105.2022.12.12.14.59.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Dec 2022 14:59:21 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250772 Archived-At: Randy Taylor writes: > On Monday, December 12th, 2022 at 03:28, Eshel Yaron via "Bug reports > for GNU Emacs, the Swiss army knife of text editors" > wrote: >>=20 >> Randy Taylor dev@rjt.dev writes: >>=20 >> > On Sunday, December 11th, 2022 at 18:57, Randy Taylor dev@rjt.dev = wrote: >> >=20 >> > I didn't notice this because I use conult-imenu, which will add an >> > index for any duplicates. imenu doesn't do this, and for other = modes >> > like c-mode, c++-mode, org-mode, etc., only the first entry gets >> > shown. >> >=20 >> > I've attached a patch which will use the stage name if it's = available, >> > otherwise use the base image. >>=20 >>=20 >> Great :) That's certainly an improvement. >>=20 >> I still maintain that using the base image as an identifier of the = build >> stage is not that useful, it doesn't really identify the stage in any >> way, like identifying functions their arguments doesn't make a lot of >> sense. I do see how in practice that'll probably be fine in most = cases. >>=20 > > We don't get any information about which stage is which beyond the > base image and potential alias (which is all Dockerfiles themselves > have anyway), so we would need to track that stuff ourselves, and I > don't think it's worth the complexity. Dockerfiles give us a solution > to this anyway: use aliases. > > Perhaps consider trying a different imenu implementation? I use > consult-imenu which gives indexes for any duplicates (it also flattens > imenu which I really like). Maybe someone could add something like > that to imenu. > > Can someone install the patch? Thanks. Applied, thanks! I=E2=80=99ll leave closing the report to one of you = guys :-) Yuan