all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#65655: 30.0.50; Minor oversights in integer->natnum :type change
@ 2023-08-31 10:52 Mauro Aranda
  2023-09-01 20:20 ` Stefan Kangas
  0 siblings, 1 reply; 2+ messages in thread
From: Mauro Aranda @ 2023-08-31 10:52 UTC (permalink / raw)
  To: 65655

The type of the following two options was changed from integer to natnum:
blink-cursor-blinks and url-max-redirections
as part of this commit:

commit 9d866a1f8da870dcf82f87d5ed9d5ca932d5477b
Author: Stefan Kangas <stefankangas@gmail.com>
Date:   Tue Jul 5 16:26:45 2022 +0200

     Make some defcustom types more restrictive


But the docstring of blink-cursor-blinks says:
"Use 0 or negative value to blink forever."
Now a negative value can't be used, so it would be good to adapt the
docstring, at least.

And the docstring of url-max-redirections says:
"A negative number means to honor an unlimited number of redirection
requests."
I suggest to change its type back to integer.






^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#65655: 30.0.50; Minor oversights in integer->natnum :type change
  2023-08-31 10:52 bug#65655: 30.0.50; Minor oversights in integer->natnum :type change Mauro Aranda
@ 2023-09-01 20:20 ` Stefan Kangas
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Kangas @ 2023-09-01 20:20 UTC (permalink / raw)
  To: Mauro Aranda; +Cc: 65655-done

Version: 29.2

Mauro Aranda <maurooaranda@gmail.com> writes:

> But the docstring of blink-cursor-blinks says:
> "Use 0 or negative value to blink forever."
> Now a negative value can't be used, so it would be good to adapt the
> docstring, at least.
>
> And the docstring of url-max-redirections says:
> "A negative number means to honor an unlimited number of redirection
> requests."
> I suggest to change its type back to integer.

Thanks for spotting these issues.

Fixed on emacs-29 in commit 60dcea7658a.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-01 20:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-31 10:52 bug#65655: 30.0.50; Minor oversights in integer->natnum :type change Mauro Aranda
2023-09-01 20:20 ` Stefan Kangas

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.