* bug#60137: [PATCH] ; Put built-in modes first for eglot-server-programs
@ 2022-12-17 2:48 Randy Taylor
2022-12-17 23:44 ` Yuan Fu
2022-12-18 8:22 ` Yuan Fu
0 siblings, 2 replies; 6+ messages in thread
From: Randy Taylor @ 2022-12-17 2:48 UTC (permalink / raw)
To: 60137
[-- Attachment #1.1: Type: text/plain, Size: 24 bytes --]
Per Stefan's suggestion.
[-- Attachment #1.2: Type: text/html, Size: 460 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Put-built-in-modes-first-for-eglot-server-programs.patch --]
[-- Type: text/x-patch; name=0001-Put-built-in-modes-first-for-eglot-server-programs.patch, Size: 3136 bytes --]
From a6b50cadc091f7d684331211bbe140bde3d42ffd Mon Sep 17 00:00:00 2001
From: Randy Taylor <dev@rjt.dev>
Date: Fri, 16 Dec 2022 21:32:40 -0500
Subject: [PATCH] ; Put built-in modes first for eglot-server-programs
* lisp/progmodes/eglot.el (eglot-server-programs): Put built-in modes first.
---
lisp/progmodes/eglot.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 20534cfa1c..a9dd794fa6 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -183,12 +183,12 @@ eglot-alternatives
finally (funcall err)))))))
(defvar eglot-server-programs `((rust-mode . ,(eglot-alternatives '("rust-analyzer" "rls")))
- ((cmake-mode cmake-ts-mode) . ("cmake-language-server"))
+ ((cmake-ts-mode cmake-mode) . ("cmake-language-server"))
(vimrc-mode . ("vim-language-server" "--stdio"))
((python-mode python-ts-mode)
. ,(eglot-alternatives
'("pylsp" "pyls" ("pyright-langserver" "--stdio") "jedi-language-server")))
- ((js-json-mode json-mode json-ts-mode)
+ ((js-json-mode json-ts-mode json-mode)
. ,(eglot-alternatives '(("vscode-json-language-server" "--stdio")
("json-languageserver" "--stdio"))))
((js-mode js-ts-mode tsx-ts-mode typescript-ts-mode typescript-mode)
@@ -211,7 +211,7 @@ eglot-server-programs
(elm-mode . ("elm-language-server"))
(mint-mode . ("mint" "ls"))
(kotlin-mode . ("kotlin-language-server"))
- ((go-mode go-dot-mod-mode go-dot-work-mode go-ts-mode go-mod-ts-mode)
+ ((go-ts-mode go-mod-ts-mode go-mode go-dot-mod-mode go-dot-work-mode)
. ("gopls"))
((R-mode ess-r-mode) . ("R" "--slave" "-e"
"languageserver::run()"))
@@ -237,7 +237,7 @@ eglot-server-programs
. ,(eglot-alternatives '(("vscode-css-language-server" "--stdio")
("css-languageserver" "--stdio"))))
(html-mode . ,(eglot-alternatives '(("vscode-html-language-server" "--stdio") ("html-languageserver" "--stdio"))))
- ((dockerfile-mode dockerfile-ts-mode) . ("docker-langserver" "--stdio"))
+ ((dockerfile-ts-mode dockerfile-mode) . ("docker-langserver" "--stdio"))
((clojure-mode clojurescript-mode clojurec-mode)
. ("clojure-lsp"))
((csharp-mode csharp-ts-mode)
--
2.39.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#60137: [PATCH] ; Put built-in modes first for eglot-server-programs
2022-12-17 2:48 bug#60137: [PATCH] ; Put built-in modes first for eglot-server-programs Randy Taylor
@ 2022-12-17 23:44 ` Yuan Fu
2022-12-18 1:56 ` Randy Taylor
2022-12-18 8:22 ` Yuan Fu
1 sibling, 1 reply; 6+ messages in thread
From: Yuan Fu @ 2022-12-17 23:44 UTC (permalink / raw)
To: Randy Taylor; +Cc: 60137, Stefan Kangas
Randy Taylor <dev@rjt.dev> writes:
> Per Stefan's suggestion.
Does the ordering matter? CC’d Stefan.
Yuan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#60137: [PATCH] ; Put built-in modes first for eglot-server-programs
2022-12-17 23:44 ` Yuan Fu
@ 2022-12-18 1:56 ` Randy Taylor
2022-12-18 4:13 ` João Távora
0 siblings, 1 reply; 6+ messages in thread
From: Randy Taylor @ 2022-12-18 1:56 UTC (permalink / raw)
To: Yuan Fu; +Cc: 60137, Stefan Kangas, joaotavora@gmail.com
On Saturday, December 17th, 2022 at 18:44, Yuan Fu <casouri@gmail.com> wrote:
>
> Randy Taylor dev@rjt.dev writes:
>
> > Per Stefan's suggestion.
>
>
> Does the ordering matter? CC’d Stefan.
>
> Yuan
Nope, Stefan's suggestion was (from Bug#60105, which I probably should've included in the initial bug):
> This is a nit, but I think it might make more sense to users if we put
> the built-in mode first in the list. After all, the one we ship with
> Emacs is, or will be, the standard mode.
It makes sense to me, hence the patch.
I've CC'd João since eglot is his baby.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#60137: [PATCH] ; Put built-in modes first for eglot-server-programs
2022-12-18 1:56 ` Randy Taylor
@ 2022-12-18 4:13 ` João Távora
0 siblings, 0 replies; 6+ messages in thread
From: João Távora @ 2022-12-18 4:13 UTC (permalink / raw)
To: Randy Taylor; +Cc: Yuan Fu, 60137, Stefan Kangas
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
On Sun, Dec 18, 2022 at 1:57 AM Randy Taylor <dev@rjt.dev> wrote:
>
> I've CC'd João since eglot is his baby.
>
I don't mind the patch, but I don't know what it brings us either.
João
[-- Attachment #2: Type: text/html, Size: 553 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#60137: [PATCH] ; Put built-in modes first for eglot-server-programs
2022-12-17 2:48 bug#60137: [PATCH] ; Put built-in modes first for eglot-server-programs Randy Taylor
2022-12-17 23:44 ` Yuan Fu
@ 2022-12-18 8:22 ` Yuan Fu
2022-12-18 18:46 ` Randy Taylor
1 sibling, 1 reply; 6+ messages in thread
From: Yuan Fu @ 2022-12-18 8:22 UTC (permalink / raw)
To: Randy Taylor; +Cc: 60137, Stefan Kangas, joaotavora
Randy Taylor <dev@rjt.dev> writes:
> On Saturday, December 17th, 2022 at 18:44, Yuan Fu <casouri@gmail.com> wrote:
>>
>> Randy Taylor dev@rjt.dev writes:
>>
>> > Per Stefan's suggestion.
>>
>>
>> Does the ordering matter? CC’d Stefan.
>>
>> Yuan
>
> Nope, Stefan's suggestion was (from Bug#60105, which I probably should've included in the initial bug):
>> This is a nit, but I think it might make more sense to users if we put
>> the built-in mode first in the list. After all, the one we ship with
>> Emacs is, or will be, the standard mode.
>
> It makes sense to me, hence the patch.
>
> I've CC'd João since eglot is his baby.
IMHO, if it doesn’t matter, there is no need to add a commit to the
history for it. Stefan probably mentioned it because it was in a patch.
Yuan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#60137: [PATCH] ; Put built-in modes first for eglot-server-programs
2022-12-18 8:22 ` Yuan Fu
@ 2022-12-18 18:46 ` Randy Taylor
0 siblings, 0 replies; 6+ messages in thread
From: Randy Taylor @ 2022-12-18 18:46 UTC (permalink / raw)
To: Yuan Fu; +Cc: 60137-done@debbugs.gnu.org, Stefan Kangas, joaotavora
On Sunday, December 18th, 2022 at 03:22, Yuan Fu <casouri@gmail.com> wrote:
>
> Randy Taylor dev@rjt.dev writes:
>
> > On Saturday, December 17th, 2022 at 18:44, Yuan Fu casouri@gmail.com wrote:
> >
> > > Randy Taylor dev@rjt.dev writes:
> > >
> > > > Per Stefan's suggestion.
> > >
> > > Does the ordering matter? CC’d Stefan.
> > >
> > > Yuan
> >
> > Nope, Stefan's suggestion was (from Bug#60105, which I probably should've included in the initial bug):
> >
> > > This is a nit, but I think it might make more sense to users if we put
> > > the built-in mode first in the list. After all, the one we ship with
> > > Emacs is, or will be, the standard mode.
> >
> > It makes sense to me, hence the patch.
> >
> > I've CC'd João since eglot is his baby.
>
>
> IMHO, if it doesn’t matter, there is no need to add a commit to the
> history for it. Stefan probably mentioned it because it was in a patch.
>
>
> Yuan
>
I just thought it would be nice to keep everything consistent.
Closing since there's no interest.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-12-18 18:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-17 2:48 bug#60137: [PATCH] ; Put built-in modes first for eglot-server-programs Randy Taylor
2022-12-17 23:44 ` Yuan Fu
2022-12-18 1:56 ` Randy Taylor
2022-12-18 4:13 ` João Távora
2022-12-18 8:22 ` Yuan Fu
2022-12-18 18:46 ` Randy Taylor
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.