From: Juri Linkov <juri@linkov.net>
To: Trevor Spiteri <tspiteri@ieee.org>
Cc: 40919@debbugs.gnu.org
Subject: bug#40919: 27.0.91; next-error-select-buffer does not always behave as documented
Date: Wed, 29 Apr 2020 23:38:59 +0300 [thread overview]
Message-ID: <87zhau5bfw.fsf@mail.linkov.net> (raw)
In-Reply-To: <d4ee34a4-87f6-8b28-689e-d8b291df898a@ieee.org> (Trevor Spiteri's message of "Wed, 29 Apr 2020 02:13:22 +0200")
> I think the error is in the implementation.
Then I see no way other than for next-error-select-buffer to say:
"the current buffer was visited from next-error-last-buffer".
Yes, this is a lie, but a white lie with good intentions, so
next-error-find-buffer will trust this misinformation and leave
the buffer alone. Is this patch morally acceptable?
diff --git a/lisp/simple.el b/lisp/simple.el
index b5ba05426f..b5f148b7d5 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -379,7 +379,8 @@ next-error-select-buffer
(list (get-buffer
(read-buffer "Select next-error buffer: " nil nil
(lambda (b) (next-error-buffer-p (cdr b)))))))
- (setq next-error-last-buffer buffer))
+ (setq next-error-last-buffer buffer)
+ (setq next-error-buffer buffer))
(defalias 'goto-next-locus 'next-error)
(defalias 'next-match 'next-error)
next prev parent reply other threads:[~2020-04-29 20:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 1:51 bug#40919: 27.0.91; next-error-select-buffer does not always behave as documented Trevor Spiteri
2020-04-28 11:37 ` Trevor Spiteri
2020-04-28 23:40 ` Juri Linkov
2020-04-29 0:13 ` Trevor Spiteri
2020-04-29 20:38 ` Juri Linkov [this message]
2020-04-29 22:40 ` Trevor Spiteri
2020-04-30 20:14 ` Juri Linkov
2020-04-30 23:18 ` Trevor Spiteri
2020-05-02 23:38 ` Juri Linkov
2020-05-03 2:40 ` Eli Zaretskii
2020-05-03 22:36 ` Juri Linkov
2020-05-19 1:48 ` Dmitry Gutov
2020-05-19 22:21 ` Juri Linkov
2020-05-21 23:57 ` Dmitry Gutov
2020-05-23 22:24 ` Juri Linkov
2020-05-23 23:30 ` Dmitry Gutov
2020-05-24 21:48 ` Juri Linkov
2020-05-25 1:58 ` Dmitry Gutov
2020-05-25 15:17 ` Eli Zaretskii
2020-05-25 23:17 ` Dmitry Gutov
2020-05-26 16:06 ` Eli Zaretskii
2020-05-26 16:20 ` Dmitry Gutov
2020-05-26 16:33 ` Eli Zaretskii
2020-05-26 20:39 ` Dmitry Gutov
2020-05-27 19:18 ` Dmitry Gutov
2020-05-30 22:29 ` Juri Linkov
2020-06-10 23:03 ` Juri Linkov
2020-06-10 23:28 ` Dmitry Gutov
2020-06-11 13:11 ` Eli Zaretskii
2020-06-11 22:39 ` Juri Linkov
2020-06-12 7:06 ` Eli Zaretskii
2020-06-13 22:53 ` Juri Linkov
2020-06-14 23:17 ` Juri Linkov
2020-05-28 23:07 ` Dmitry Gutov
2020-06-01 22:41 ` Juri Linkov
2020-06-01 23:04 ` Dmitry Gutov
2020-06-10 23:05 ` Juri Linkov
2020-06-10 23:32 ` Dmitry Gutov
2020-06-11 22:43 ` Juri Linkov
2020-06-14 11:50 ` Dmitry Gutov
2020-06-14 23:15 ` Juri Linkov
2020-06-15 7:58 ` Dmitry Gutov
2020-06-24 23:38 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhau5bfw.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=40919@debbugs.gnu.org \
--cc=tspiteri@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.