From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#40919: 27.0.91; next-error-select-buffer does not always behave as documented Date: Wed, 29 Apr 2020 23:38:59 +0300 Organization: LINKOV.NET Message-ID: <87zhau5bfw.fsf@mail.linkov.net> References: <53913bd9-2bdc-0f70-f7b4-744283e0512f@ieee.org> <87d07rmb6j.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="65635"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 40919@debbugs.gnu.org To: Trevor Spiteri Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 29 23:00:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTtob-000Gy5-94 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Apr 2020 23:00:21 +0200 Original-Received: from localhost ([::1]:35518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTtoa-0002ZD-6s for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Apr 2020 17:00:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56862) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTtoJ-0002Xx-Cm for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 17:00:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTtoI-00060J-U3 for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 17:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33250) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTtoI-00060E-HD for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 17:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTtoI-000753-GO for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 17:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Apr 2020 21:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40919 X-GNU-PR-Package: emacs Original-Received: via spool by 40919-submit@debbugs.gnu.org id=B40919.158819396127113 (code B ref 40919); Wed, 29 Apr 2020 21:00:02 +0000 Original-Received: (at 40919) by debbugs.gnu.org; 29 Apr 2020 20:59:21 +0000 Original-Received: from localhost ([127.0.0.1]:44792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTtnc-00073F-W2 for submit@debbugs.gnu.org; Wed, 29 Apr 2020 16:59:21 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:57941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTtnb-000730-Gc for 40919@debbugs.gnu.org; Wed, 29 Apr 2020 16:59:20 -0400 Original-Received: from mail.gandi.net (m91-129-106-11.cust.tele2.ee [91.129.106.11]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 08B28100004; Wed, 29 Apr 2020 20:59:11 +0000 (UTC) In-Reply-To: (Trevor Spiteri's message of "Wed, 29 Apr 2020 02:13:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179359 Archived-At: > I think the error is in the implementation. Then I see no way other than for next-error-select-buffer to say: "the current buffer was visited from next-error-last-buffer". Yes, this is a lie, but a white lie with good intentions, so next-error-find-buffer will trust this misinformation and leave the buffer alone. Is this patch morally acceptable? diff --git a/lisp/simple.el b/lisp/simple.el index b5ba05426f..b5f148b7d5 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -379,7 +379,8 @@ next-error-select-buffer (list (get-buffer (read-buffer "Select next-error buffer: " nil nil (lambda (b) (next-error-buffer-p (cdr b))))))) - (setq next-error-last-buffer buffer)) + (setq next-error-last-buffer buffer) + (setq next-error-buffer buffer)) (defalias 'goto-next-locus 'next-error) (defalias 'next-match 'next-error)