all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Visuwesh <visuweshm@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Robert Pluim <rpluim@gmail.com>, 54646@debbugs.gnu.org
Subject: bug#54646: 29.0.50; set-fontset-font and font clipping issues
Date: Fri, 01 Apr 2022 17:08:59 +0530	[thread overview]
Message-ID: <87zgl5hw30.fsf@gmail.com> (raw)
In-Reply-To: <83ilrt5b1v.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 01 Apr 2022 13:54:04 +0300")

[வெள்ளி ஏப்ரல் 01, 2022] Eli Zaretskii wrote:

>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: 54646@debbugs.gnu.org,Eli Zaretskii <eliz@gnu.org>
>> Date: Fri, 01 Apr 2022 10:49:21 +0200
>> 
>>     Visuwesh> I can reproduce it in HarfBuzz 4.2.0.  Maybe this could be related to
>>     Visuwesh> the toolkit being used?  I have only tested so far with Lucid.  I will
>>     Visuwesh> try GTK some time later.
>> 
>> Iʼve managed to reproduce this, but only once, with HarfBuzz 4.2.0
>> using lucid and Kurinto Seri. I guess that points more at HarfBuzz
>> than at Emacs, but maybe the lucid build is doing things slightly
>> differently to gtk.
>
> I think at this point we need to establish whether we pass the same
> information to HarfBuzz in the "good" and the "bad" cases.  In
> particular, we tell it how to scale the glyph metrics:
>
>   hb_font_t *hb_font
>     = font->driver->begin_hb_font
>     ? font->driver->begin_hb_font (font, &position_unit)
>     : NULL;
>
> The value of position_unit then affects the values returned in the
> Lisp glyph object used to display the grapheme cluster:
>
>       xoff = lround (pos[i].x_offset * position_unit);
>       yoff = - lround (pos[i].y_offset * position_unit);
>       wadjust = lround (pos[i].x_advance * position_unit);
>       if (xoff || yoff || wadjust != metrics.width)
> 	LGLYPH_SET_ADJUSTMENT (lglyph, CALLN (Fvector,
> 					      make_fixnum (xoff),
> 					      make_fixnum (yoff),
> 					      make_fixnum (wadjust)));
>
> I'd be interested in what happens there in the "good" vs the "bad"
> cases.
>
> If we pass the same information to HarfBuzz, and it returns different
> results, then it's probably a problem in HarfBuzz.

If you can give some instructions on how to get started, I can try
getting the value of position_unit in the good and the bad cases.





  reply	other threads:[~2022-04-01 11:38 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31  3:37 bug#54646: 29.0.50; set-fontset-font and font clipping issues Visuwesh
2022-03-31  5:34 ` Eli Zaretskii
2022-03-31  7:03   ` Visuwesh
2022-03-31  7:11     ` Eli Zaretskii
2022-03-31  7:35       ` Visuwesh
2022-03-31  8:45       ` Visuwesh
2022-03-31  9:04         ` Eli Zaretskii
2022-03-31  9:29           ` Visuwesh
2022-03-31  9:41             ` Eli Zaretskii
2022-03-31 12:16               ` Visuwesh
2022-03-31 14:04                 ` Eli Zaretskii
2022-03-31 13:44               ` Visuwesh
2022-03-31 14:10                 ` Eli Zaretskii
2022-03-31 14:12                   ` Eli Zaretskii
2022-03-31 15:07                   ` Visuwesh
2022-03-31 16:49                     ` Eli Zaretskii
2022-03-31 17:38                       ` Robert Pluim
2022-04-01  1:05                         ` Visuwesh
2022-04-01  3:08                           ` Visuwesh
2022-04-01  8:49                             ` Robert Pluim
2022-04-01 10:54                               ` Eli Zaretskii
2022-04-01 11:38                                 ` Visuwesh [this message]
2022-04-01 12:14                                   ` Eli Zaretskii
2022-04-01 13:10                                     ` Visuwesh
2022-04-01 14:19                                       ` Eli Zaretskii
2022-04-01 14:58                                 ` Visuwesh
2022-04-01 15:27                                   ` Eli Zaretskii
2022-04-01 16:40                                     ` Visuwesh
2022-04-01 17:58                                       ` Eli Zaretskii
2022-04-03  9:15                                         ` Visuwesh
2022-04-03 10:06                                           ` Eli Zaretskii
2022-04-03 10:26                                             ` Visuwesh
2022-04-03 10:50                                               ` Eli Zaretskii
2022-04-03 11:10                                                 ` Visuwesh
2022-04-21 14:50                                                   ` Visuwesh
2022-04-22  7:23                                                     ` Eli Zaretskii
2022-04-22 10:46                                                       ` Visuwesh
2022-04-22 10:48                                                         ` Eli Zaretskii
2022-06-11 13:54                                                           ` Visuwesh
2022-06-12  1:34                                                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-12  5:55                                                               ` Eli Zaretskii
2022-06-12  4:49                                                             ` Visuwesh
2022-06-12  5:53                                                             ` Eli Zaretskii
2022-06-12  7:47                                                               ` Visuwesh
2022-06-12 10:16                                                                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-08 11:48                                                             ` Visuwesh
2022-10-08 12:42                                                               ` Eli Zaretskii
2022-10-08 12:53                                                                 ` Visuwesh
2022-10-08 13:00                                                                   ` Eli Zaretskii
2022-10-09 11:31                                                                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-09 11:59                                                                     ` Visuwesh
2022-03-31  7:48     ` Eli Zaretskii
2022-03-31  8:47       ` Visuwesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgl5hw30.fsf@gmail.com \
    --to=visuweshm@gmail.com \
    --cc=54646@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.