all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Visuwesh <visuweshm@gmail.com>
Cc: rpluim@gmail.com, 54646@debbugs.gnu.org
Subject: bug#54646: 29.0.50; set-fontset-font and font clipping issues
Date: Sun, 03 Apr 2022 13:06:49 +0300	[thread overview]
Message-ID: <83y20m32h2.fsf@gnu.org> (raw)
In-Reply-To: <874k3aede0.fsf@gmail.com> (message from Visuwesh on Sun, 03 Apr 2022 14:45:35 +0530)

> From: Visuwesh <visuweshm@gmail.com>
> Cc: rpluim@gmail.com,  54646@debbugs.gnu.org
> Date: Sun, 03 Apr 2022 14:45:35 +0530
> 
> > It's hard to understand what you printed out, or where is the
> > difference.  It is best to print only the data for the characters for
> > which you see display problems, because all the rest is just clutter.
> > And in any case, please print the character with the data, otherwise
> > it is impossible to know what to compare.
> 
> I used the %c printf format control to print the character in
> question---chars[char_idx].  comment-section-good is the "good" case and
> comment-section-bad is the "bad" case.  The URL I browsed in eww is
> https://www.dinamalar.com/news_detail.asp?id=2998931 (isearch for
> "Suppon" to get to the comment section).  Unfortunately, all the
> characters are in raw bytes so if there's a better to print the
> characters, please let me know.

The %c format is only good for single-byte characters, which these
ones aren't.  Please use %x to print them (in hex).

Also, I think printing everything is too much, and doesn't allow to
focus.  Please print only when the character's code is one of those
involved in the problematic display.  "C-u C-x =" will tell you the
codepoints of the characters involved: the one that is displayed
incorrectly and the ones surrounding it: please add an 'if' clause
there which would only print the metrics data for the characters in
which we are interested.  Something like this:

  if (chars[char_idx] == CHAR1
      || chars[char_idx] == CHAR2
      || chars[char_idx] == CHAR3)
    printf (...

where CHAR1, CHAR2, and CHAR3 are the characters involved in the
problematic display, according to "C-u C-x =".

May I suggest that you show me the code you add to hbfont.c before you
run it?  This would avoid unnecessary iterations for you.

Thanks.





  reply	other threads:[~2022-04-03 10:06 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31  3:37 bug#54646: 29.0.50; set-fontset-font and font clipping issues Visuwesh
2022-03-31  5:34 ` Eli Zaretskii
2022-03-31  7:03   ` Visuwesh
2022-03-31  7:11     ` Eli Zaretskii
2022-03-31  7:35       ` Visuwesh
2022-03-31  8:45       ` Visuwesh
2022-03-31  9:04         ` Eli Zaretskii
2022-03-31  9:29           ` Visuwesh
2022-03-31  9:41             ` Eli Zaretskii
2022-03-31 12:16               ` Visuwesh
2022-03-31 14:04                 ` Eli Zaretskii
2022-03-31 13:44               ` Visuwesh
2022-03-31 14:10                 ` Eli Zaretskii
2022-03-31 14:12                   ` Eli Zaretskii
2022-03-31 15:07                   ` Visuwesh
2022-03-31 16:49                     ` Eli Zaretskii
2022-03-31 17:38                       ` Robert Pluim
2022-04-01  1:05                         ` Visuwesh
2022-04-01  3:08                           ` Visuwesh
2022-04-01  8:49                             ` Robert Pluim
2022-04-01 10:54                               ` Eli Zaretskii
2022-04-01 11:38                                 ` Visuwesh
2022-04-01 12:14                                   ` Eli Zaretskii
2022-04-01 13:10                                     ` Visuwesh
2022-04-01 14:19                                       ` Eli Zaretskii
2022-04-01 14:58                                 ` Visuwesh
2022-04-01 15:27                                   ` Eli Zaretskii
2022-04-01 16:40                                     ` Visuwesh
2022-04-01 17:58                                       ` Eli Zaretskii
2022-04-03  9:15                                         ` Visuwesh
2022-04-03 10:06                                           ` Eli Zaretskii [this message]
2022-04-03 10:26                                             ` Visuwesh
2022-04-03 10:50                                               ` Eli Zaretskii
2022-04-03 11:10                                                 ` Visuwesh
2022-04-21 14:50                                                   ` Visuwesh
2022-04-22  7:23                                                     ` Eli Zaretskii
2022-04-22 10:46                                                       ` Visuwesh
2022-04-22 10:48                                                         ` Eli Zaretskii
2022-06-11 13:54                                                           ` Visuwesh
2022-06-12  1:34                                                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-12  5:55                                                               ` Eli Zaretskii
2022-06-12  4:49                                                             ` Visuwesh
2022-06-12  5:53                                                             ` Eli Zaretskii
2022-06-12  7:47                                                               ` Visuwesh
2022-06-12 10:16                                                                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-08 11:48                                                             ` Visuwesh
2022-10-08 12:42                                                               ` Eli Zaretskii
2022-10-08 12:53                                                                 ` Visuwesh
2022-10-08 13:00                                                                   ` Eli Zaretskii
2022-10-09 11:31                                                                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-09 11:59                                                                     ` Visuwesh
2022-03-31  7:48     ` Eli Zaretskii
2022-03-31  8:47       ` Visuwesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y20m32h2.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=54646@debbugs.gnu.org \
    --cc=rpluim@gmail.com \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.