From: "João Távora" <joaotavora@gmail.com>
To: 56407@debbugs.gnu.org
Cc: Morten Welinder <terra@diku.dk>
Subject: bug#56407: 29.0.50; desktop.el shouldn't be saving/restoring eglot--managed-mode, which is not for interactive use
Date: Tue, 05 Jul 2022 20:34:16 +0100 [thread overview]
Message-ID: <87y1x7pd53.fsf@gmail.com> (raw)
Hi Morten, maintainers,
Recently, in https://github.com/joaotavora/eglot/issues/990, we found
out that users of both eglot.el and desktop.el were getting errors when
restarting Emacs. That's because desktop.el attempts to re-enable the
eglot--managed-mode minor mode which was "on" when they saved the
session (presumably on exit).
I confirmed this with a stack trace requested from the user and came up
with this workaround in the user's config:
(add-to-list 'desktop-minor-mode-handlers
'(eglot--managed-mode . ignore))
This works, but we should come up with something better.
In Eglot, the eglot--managed-mode minor mode is an implementation
detail, it is NOT meant to be called by the user, since it requires a
number of preconditions (like firing up a successful server) to be met.
Therefore, I have named the symbol with the "internal symbol"
convention. In this very simple patch, I teach desktop.el to watch out
for this convention and not restart that mode.
diff --git a/lisp/desktop.el b/lisp/desktop.el
index 1a4103e209..a93703a77e 100644
--- a/lisp/desktop.el
+++ b/lisp/desktop.el
@@ -1617,7 +1617,9 @@ desktop-create-buffer
(let ((handler (cdr (assq minor-mode desktop-minor-mode-handlers))))
(if handler
(funcall handler desktop-buffer-locals)
- (when (functionp minor-mode)
+ (when (or (functionp minor-mode)
+ (and (symbolp minor-mode)
+ (not (string-match "^[^-]+--" (symbol-name minor-mode)))))
(funcall minor-mode 1)))))))
;; Even though point and mark are non-nil when written by
;; `desktop-save', they may be modified by handlers wanting to set
This probably works (though I haven't tested), but maybe we could come
up with some other way around this, like having eglot.el propertize its
'eglot--managed-mode' symbol so that desktop.el doesn't even write it
onto the user's save file. Or something like that.
Thanks,
João
next reply other threads:[~2022-07-05 19:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 19:34 João Távora [this message]
2022-07-05 19:40 ` bug#56407: 29.0.50; desktop.el shouldn't be saving/restoring eglot--managed-mode, which is not for interactive use Eli Zaretskii
2022-07-05 19:53 ` João Távora
2022-07-06 2:29 ` Eli Zaretskii
2022-07-06 8:12 ` João Távora
2022-07-06 11:09 ` Eli Zaretskii
2022-07-06 11:30 ` João Távora
2022-07-06 11:37 ` Lars Ingebrigtsen
2022-07-06 12:48 ` Eli Zaretskii
2022-07-06 12:59 ` João Távora
2022-07-06 13:12 ` Eli Zaretskii
2022-07-06 13:19 ` João Távora
2022-07-06 13:23 ` João Távora
2022-07-06 13:39 ` Stefan Kangas
2022-07-06 13:47 ` João Távora
2022-07-06 13:52 ` Stefan Kangas
2022-07-06 13:52 ` Lars Ingebrigtsen
2022-07-06 13:59 ` João Távora
2022-07-05 22:52 ` João Távora
2022-07-06 2:34 ` Eli Zaretskii
2022-07-06 8:27 ` João Távora
2022-07-05 19:41 ` Lars Ingebrigtsen
2022-07-05 19:56 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1x7pd53.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=56407@debbugs.gnu.org \
--cc=terra@diku.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.