From: "Herbert J. Skuhra" <herbert@gojira.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Po Lu" <luangruo@yahoo.com>,
"Gerd Möllmann" <gerd.moellmann@gmail.com>,
65609@debbugs.gnu.org, "Andrew Scott" <andj.scott@gmail.com>
Subject: bug#65609: 30.0.50; inhibit-eol-conversion breaks revert-buffer
Date: Wed, 30 Aug 2023 19:06:14 +0200 [thread overview]
Message-ID: <87y1hspiih.wl-herbert@gojira.at> (raw)
In-Reply-To: <837cpchd9w.fsf@gnu.org>
On Wed, 30 Aug 2023 15:26:35 +0200, Eli Zaretskii wrote:
>
> > From: Andrew Scott <andj.scott@gmail.com>
> > Date: Tue, 29 Aug 2023 16:45:39 +0100
> >
> > It appears that inhibit-eol-conversion breaks insert-file-contents's
> > replace functionality when a change was made in the middle of the file
> > to be reverted as the file contents get duplicated in the buffer. The
> > issue can be reproduced on a fresh Emacs with a file named bug.el with
> > contents:
> >
> > ;; 1. Launch Emacs: nix run emacs-overlay#emacs-git -- bug.el -Q --load bug.el
> > ;; 2. Outside of Emacs, add text in below empty line:
> > ;; 3. In Emacs, revert-buffer
> >
> > (setq inhibit-eol-conversion t)
> >
> > The contents of the buffer after revert-buffer:
> >
> > ;; 1. Launch Emacs: nix run emacs-overlay#emacs-git -- bug.el -Q --load bug.el
> > ;; 2. Outside of Emacs, add text in below empty line:
> > ;; 3. In Emacs, revert-buffer
> > foo
> > (setq inhibit-eol-conversion t)
> >
> > (setq inhibit-eol-conversion t)
>
> Thanks for an easy test case. We are reading too much from the file
> on disk when reverting in this case.
>
> Po Lu, I think we need the patch below to fix this. Gerd, does this
> solve your problem as well, including the abort during bootstrap?
> Herbert, I think this could also be related to the problems you see,
> so please try the patch below.
Thanks. Unfortunately this change does not resolve my issue opening
org-files. I still have to revert 4e8d579f3da.
--
Herbert
prev parent reply other threads:[~2023-08-30 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 15:45 bug#65609: 30.0.50; inhibit-eol-conversion breaks revert-buffer Andrew Scott
2023-08-30 13:26 ` Eli Zaretskii
2023-08-30 13:42 ` Gerd Möllmann
2023-08-30 14:22 ` Eli Zaretskii
2023-08-30 13:43 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 14:18 ` Eli Zaretskii
[not found] ` <CAEtA7Wfv8UauiVpjJ669-R=QdC-u32mOhn_S+hQTUr3_9_zK=g@mail.gmail.com>
2023-09-03 15:51 ` Eli Zaretskii
2023-08-30 17:06 ` Herbert J. Skuhra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1hspiih.wl-herbert@gojira.at \
--to=herbert@gojira.at \
--cc=65609@debbugs.gnu.org \
--cc=andj.scott@gmail.com \
--cc=eliz@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.