From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Herbert J. Skuhra" Newsgroups: gmane.emacs.bugs Subject: bug#65609: 30.0.50; inhibit-eol-conversion breaks revert-buffer Date: Wed, 30 Aug 2023 19:06:14 +0200 Message-ID: <87y1hspiih.wl-herbert@gojira.at> References: <837cpchd9w.fsf@gnu.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15224"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , Gerd =?UTF-8?Q?M=C3=B6llmann?= , 65609@debbugs.gnu.org, Andrew Scott To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 30 19:07:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbOer-0003hH-GQ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Aug 2023 19:07:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbOee-0007GQ-Vk; Wed, 30 Aug 2023 13:06:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbOed-0007EG-0c for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 13:06:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbOec-0007UG-Op for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 13:06:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbOek-0008Fc-Cq for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 13:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Herbert J. Skuhra" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Aug 2023 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65609 X-GNU-PR-Package: emacs Original-Received: via spool by 65609-submit@debbugs.gnu.org id=B65609.169341519631681 (code B ref 65609); Wed, 30 Aug 2023 17:07:02 +0000 Original-Received: (at 65609) by debbugs.gnu.org; 30 Aug 2023 17:06:36 +0000 Original-Received: from localhost ([127.0.0.1]:53902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbOeJ-0008Ev-Su for submit@debbugs.gnu.org; Wed, 30 Aug 2023 13:06:36 -0400 Original-Received: from mout-u-204.mailbox.org ([80.241.59.204]:47752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbOeG-0008Eg-Gw for 65609@debbugs.gnu.org; Wed, 30 Aug 2023 13:06:33 -0400 Original-Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4RbW0S5fgPz9sQT; Wed, 30 Aug 2023 19:06:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gojira.at; s=MBO0001; t=1693415176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VAuy+B21MzgPjX7Q2uOUYSt+taPIm8aXBHGYGzZi6b0=; b=PXx+3/qyDZIfs/snHnbGHT7itKQCtGGshhlAzUtXkdv4p3eOy0od9bxB/pwPGLtI106trv GXWTHF2EAamPBAbPYqVpodgtjYAwp0qUNLuWkX3yMzhELa1xGXhD3Y6UjXqS1V7UjzM1UD C471Wm8h1+7bRyZmsN3kMAwdg8rJ7+U6UxtIzKrsA0/BQWhrlVLItbWj5atqs/41zPl8XB Sa90bUPzTWbvtV9BMsB022pkX1EtDJ0+Ehjby15WhjoVnk2/a0iL3NF6PVSGOMNBnxl5Pa eRrfpSLoND3wK4aJu0Z90fTCaeLdLw3QczGCtcnvTRNP5haqUjdQfAV55kB0eA== In-Reply-To: <837cpchd9w.fsf@gnu.org> X-Rspamd-Queue-Id: 4RbW0S5fgPz9sQT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268737 Archived-At: On Wed, 30 Aug 2023 15:26:35 +0200, Eli Zaretskii wrote: > > > From: Andrew Scott > > Date: Tue, 29 Aug 2023 16:45:39 +0100 > > > > It appears that inhibit-eol-conversion breaks insert-file-contents's > > replace functionality when a change was made in the middle of the file > > to be reverted as the file contents get duplicated in the buffer. The > > issue can be reproduced on a fresh Emacs with a file named bug.el with > > contents: > > > > ;; 1. Launch Emacs: nix run emacs-overlay#emacs-git -- bug.el -Q --load bug.el > > ;; 2. Outside of Emacs, add text in below empty line: > > ;; 3. In Emacs, revert-buffer > > > > (setq inhibit-eol-conversion t) > > > > The contents of the buffer after revert-buffer: > > > > ;; 1. Launch Emacs: nix run emacs-overlay#emacs-git -- bug.el -Q --load bug.el > > ;; 2. Outside of Emacs, add text in below empty line: > > ;; 3. In Emacs, revert-buffer > > foo > > (setq inhibit-eol-conversion t) > > > > (setq inhibit-eol-conversion t) > > Thanks for an easy test case. We are reading too much from the file > on disk when reverting in this case. > > Po Lu, I think we need the patch below to fix this. Gerd, does this > solve your problem as well, including the abort during bootstrap? > Herbert, I think this could also be related to the problems you see, > so please try the patch below. Thanks. Unfortunately this change does not resolve my issue opening org-files. I still have to revert 4e8d579f3da. -- Herbert