From: Augusto Stoffel <arstoffel@gmail.com>
To: Philip Kaludercic <philipk@posteo.net>
Cc: john muhl <jm@pub.pink>,
maurooaranda@gmail.com, 65673@debbugs.gnu.org,
~emacs/emacs-devel@lists.sr.ht
Subject: bug#65673: [PATCH] Add lua-ts-mode
Date: Sun, 10 Sep 2023 14:57:30 +0200 [thread overview]
Message-ID: <87y1hechj9.fsf@gmail.com> (raw)
In-Reply-To: <87msxuxowe.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 10 Sep 2023 11:12:49 +0000")
On Sun, 10 Sep 2023 at 11:12, Philip Kaludercic wrote:
> john muhl <jm@pub.pink> writes:
>> +(defcustom lua-ts-luacheck-program (executable-find "luacheck")
>
> It is better not to hard-code the path to lua during loading, in case
> the executable is moved around, since you will basically always still be
> querying PATH when starting a new process.
>
>> + "Location of the Luacheck program."
>> + :type '(choice (const nil) (file :must-match t))
>
> Which is why I think that this shouldn't be a file.
>> +(defcustom lua-ts-inferior-program (executable-find "lua")
>> + "Program to run in the inferior Lua process."
>> + :type '(choice (const nil) (file :must-match t))
>> + :group 'lua
>> + :version "30.1")
> Same here.
Good point, calling `executable-find' at this stage will also preclude
working over Tramp, among other potential issues.
next prev parent reply other threads:[~2023-09-10 12:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 22:55 bug#65673: [PATCH emacs 0/1] Add lua-ts-mode ~johnmuhl
2023-08-31 21:32 ` bug#65672: [PATCH emacs 1/1] " ~johnmuhl
2023-09-02 12:14 ` bug#65673: [PATCH emacs 0/1] " Philip Kaludercic
2023-09-02 14:10 ` bug#65672: [PATCH emacs 1/1] " Augusto Stoffel
[not found] ` <handler.65672.B.169354983214451.ack@debbugs.gnu.org>
2023-09-04 14:36 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-04 15:18 ` Eli Zaretskii
2023-09-04 15:54 ` Philip Kaludercic
2023-09-01 22:46 ` bug#65673: [PATCH emacs 0/1] " Mauro Aranda
2023-09-09 15:17 ` bug#65673: [PATCH emacs 1/1 v2] " john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-09 15:17 ` bug#65673: [PATCH] " john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-10 11:12 ` Philip Kaludercic
2023-09-10 12:57 ` Augusto Stoffel [this message]
2023-09-11 15:03 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-16 10:03 ` Eli Zaretskii
2023-09-16 11:17 ` Eli Zaretskii
2023-09-16 11:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1hechj9.fsf@gmail.com \
--to=arstoffel@gmail.com \
--cc=65673@debbugs.gnu.org \
--cc=jm@pub.pink \
--cc=maurooaranda@gmail.com \
--cc=philipk@posteo.net \
--cc=~emacs/emacs-devel@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.