From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#65673: [PATCH] Add lua-ts-mode Date: Sun, 10 Sep 2023 14:57:30 +0200 Message-ID: <87y1hechj9.fsf@gmail.com> References: <169352253839.28940.16024479871485106701-0@git.sr.ht> <20230909151834.3613907-1-jm@pub.pink> <20230909151834.3613907-2-jm@pub.pink> <87msxuxowe.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7194"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: john muhl , maurooaranda@gmail.com, 65673@debbugs.gnu.org, ~emacs/emacs-devel@lists.sr.ht To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 10 14:58:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfK14-0001e1-F3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Sep 2023 14:58:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfK0m-00023D-GD; Sun, 10 Sep 2023 08:58:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfK0k-00021V-S8 for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 08:57:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfK0k-0002Af-6f for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 08:57:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfK0n-00067n-KW for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 08:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2023 12:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65673 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65673-submit@debbugs.gnu.org id=B65673.169435066923525 (code B ref 65673); Sun, 10 Sep 2023 12:58:01 +0000 Original-Received: (at 65673) by debbugs.gnu.org; 10 Sep 2023 12:57:49 +0000 Original-Received: from localhost ([127.0.0.1]:49231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfK0a-00067M-LU for submit@debbugs.gnu.org; Sun, 10 Sep 2023 08:57:48 -0400 Original-Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:59426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfK0V-000674-Ee for 65673@debbugs.gnu.org; Sun, 10 Sep 2023 08:57:46 -0400 Original-Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-52a49a42353so4651516a12.2 for <65673@debbugs.gnu.org>; Sun, 10 Sep 2023 05:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694350653; x=1694955453; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=GYc9uAVXS58gDdvPzHhExfjUH/zl76+Bjiqkd0EwYtc=; b=UCIPhxLWjEXJacZwWAvOhW3osRNHOk6KwhokH++gvSReqbIVCpDb1zWlF3mN/HMX5r 7+5JYgSEOICsvidIIgwy1kPMYdE5MrRqAnKb0AjVA3s+pQYtQglNKxvIGWl0XVKXKMAr t5pCllPpyBNRowAO+4sYvNrLD6iXSIdZA/2mlDVL4lhSR3ro+Eyib58Oj6O3Cqmve6Oo 6JEJj8qItIbfOzsEu+jszpYyUs6wC1iuePapyd5jVYiiT4DJX9Swnr1I+HBR8E0c8LNL 2/vAMW9LTR0GdEgLdUwJxp1HYeHI8S0LQzZMTI/gViPcNLwm5P2jqko6Q0kFU2lPO6dS mLOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694350653; x=1694955453; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GYc9uAVXS58gDdvPzHhExfjUH/zl76+Bjiqkd0EwYtc=; b=t9L/q/OQuK3emp+VkP4gxPw6YHFBFxaSUCGyeOLZl+aSc76fW39eMvgeAdunOQzzjD EWOv0h+Ic8D+UjqoQ06wyA6oGcLcdYgfRi35y8s+Fgp6Q2+ws0Dm8OQJITdgFyBrYHDt J6grqrILYmp8OFirdHRSxB5TIkKsECHwXspOnmE8SlVxwRuKsqsBF2beESDkfAwuIQZ1 lBPMY3Dg4czCT6GBjpfFEf0gkf8/uWQlp9xN1nQ++vYMisZ790tgxhONCiclAPTRbs89 iCSAlgURVsGJa0nl1IfZumHngfyqH6b8Cm3sF3f/PruRs6sX4e68j1NfSa9XLOxM75Rs aezA== X-Gm-Message-State: AOJu0Yw7Srx2Eu4F/ejufeOGa4c/I/5XIp4J7Fb/2b80oHZNNedt8KqO zC1uy5XDm5FgEMKkSgFxwwA= X-Google-Smtp-Source: AGHT+IH2TU0l9Jp+dTudlc1AiTk3MKKnADHXAU/ffBKt/Lf0vu8v1F46iZ+s9HQuNsOYVv66GyuV0Q== X-Received: by 2002:aa7:c3d4:0:b0:51e:309:2e11 with SMTP id l20-20020aa7c3d4000000b0051e03092e11mr5729291edr.36.1694350652889; Sun, 10 Sep 2023 05:57:32 -0700 (PDT) Original-Received: from ars3 (ip5f5aefc6.dynamic.kabel-deutschland.de. [95.90.239.198]) by smtp.gmail.com with ESMTPSA id w15-20020a50fa8f000000b005272523b162sm3333454edr.69.2023.09.10.05.57.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Sep 2023 05:57:31 -0700 (PDT) In-Reply-To: <87msxuxowe.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 10 Sep 2023 11:12:49 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269957 Archived-At: On Sun, 10 Sep 2023 at 11:12, Philip Kaludercic wrote: > john muhl writes: >> +(defcustom lua-ts-luacheck-program (executable-find "luacheck") > > It is better not to hard-code the path to lua during loading, in case > the executable is moved around, since you will basically always still be > querying PATH when starting a new process. > >> + "Location of the Luacheck program." >> + :type '(choice (const nil) (file :must-match t)) > > Which is why I think that this shouldn't be a file. >> +(defcustom lua-ts-inferior-program (executable-find "lua") >> + "Program to run in the inferior Lua process." >> + :type '(choice (const nil) (file :must-match t)) >> + :group 'lua >> + :version "30.1") > Same here. Good point, calling `executable-find' at this stage will also preclude working over Tramp, among other potential issues.