all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "J.P." <jp@neverwas.me>
To: 59943@debbugs.gnu.org
Cc: emacs-erc@gnu.org
Subject: bug#59943: 30.0.50; ERC 5.5+: Add visual indicator to ERC keep-place
Date: Sun, 07 Jan 2024 21:47:39 -0800	[thread overview]
Message-ID: <87y1d01imc.fsf__25006.1977816344$1704692900$gmane$org@neverwas.me> (raw)
In-Reply-To: <87ttnv23n8.fsf@neverwas.me> (J. P.'s message of "Tue, 02 Jan 2024 06:47:39 -0800")

"J.P." <jp@neverwas.me> writes:

>>From emacs -Q
>
>   1. M-: (setopt erc-keep-place-indicator-follow t) RET
>      M-x erc RET ... RET
>
>   2. In the server buffer, do M-x erc-keep-place-indicator-mode RET
>
>   3. Scroll "up" to hide the indicator but not so far that point moves
>      beyond `erc-insert-marker'
>
>   4. Switch away to another buffer and then back
>
>   5. Notice the indicator fails to update
>
> This happens because `keep-place-indicator' is a local module, and it
> adds `erc--keep-place-indicator-on-window-buffer-change' to the hook
> `window-buffer-change-functions' locally. But that function needs to run
> in the buffer that's being switched to, which may not have the mode
> enabled (and thus not have the hook member available). Subscribing to
> the hook globally should fix the problem. There are also at least two
> bugs affecting the integration between `keep-place-indicator' and
> `keep-place'. The attached patch attempts to address these as well.

This has been installed as:

  fad2d1e2acc * Use global window hook for erc-keep-place-indicator

This bug is already closed.





  reply	other threads:[~2024-01-08  5:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87fsdndzo1.fsf@neverwas.me>
2022-12-16 14:26 ` bug#59943: 30.0.50; ERC 5.5+: Add visual indicator to ERC keep-place J.P.
     [not found] ` <87bko3jug8.fsf@neverwas.me>
2023-02-01  2:49   ` J.P.
2023-02-20 15:33 ` J.P.
2023-03-09 14:41 ` J.P.
2023-07-14  2:03 ` J.P.
2024-01-02 14:47 ` J.P.
2024-01-08  5:47   ` J.P. [this message]
2022-12-10 15:52 J.P.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87y1d01imc.fsf__25006.1977816344$1704692900$gmane$org@neverwas.me' \
    --to=jp@neverwas.me \
    --cc=59943@debbugs.gnu.org \
    --cc=emacs-erc@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.