From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#59943: 30.0.50; ERC 5.5+: Add visual indicator to ERC keep-place Date: Sun, 07 Jan 2024 21:47:39 -0800 Message-ID: <87y1d01imc.fsf__25006.1977816344$1704692900$gmane$org@neverwas.me> References: <87fsdndzo1.fsf@neverwas.me> <87ttnv23n8.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36903"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 59943@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 08 06:48:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rMiUe-0009S2-OA for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Jan 2024 06:48:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMiUQ-0006ws-7B; Mon, 08 Jan 2024 00:47:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMiUO-0006wC-8i for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 00:47:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rMiUO-0007Me-0U for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 00:47:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rMiUT-0005oV-VC for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 00:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jan 2024 05:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59943-submit@debbugs.gnu.org id=B59943.170469287522299 (code B ref 59943); Mon, 08 Jan 2024 05:48:01 +0000 Original-Received: (at 59943) by debbugs.gnu.org; 8 Jan 2024 05:47:55 +0000 Original-Received: from localhost ([127.0.0.1]:34855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMiUM-0005nZ-Uy for submit@debbugs.gnu.org; Mon, 08 Jan 2024 00:47:55 -0500 Original-Received: from mail-108-mta63.mxroute.com ([136.175.108.63]:40605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMiUL-0005nH-2E for 59943@debbugs.gnu.org; Mon, 08 Jan 2024 00:47:53 -0500 Original-Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta63.mxroute.com (ZoneMTA) with ESMTPSA id 18ce79ccf830003727.001 for <59943@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 08 Jan 2024 05:47:42 +0000 X-Zone-Loop: f591a6cdf4a94f097391814d02e3f782be327b17abf2 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RuUp8fmE218CjzCUl3iKd7DrN6WRuq9e298IFDHSy84=; b=CEtMBtlucLP8jb/rMQ5vAi6VdA vQLPe6hO3LbvZ5xME/yU9Hnxh5vUIaeArROu4+JWIRkO07AdLZd4u5t0pS2/4hsAzvF+5akxTGNgr 3UB9SU+W2PqG0GkQ8I3Qee6bpsxzZNJ4VSuwUneeXjWoDMS0Nka93D5F2TPJSwCzQANqWUsLp3d7j eKXDR2pDOs114H8e2ZeUL4g2bMwLTIi34ZpaSYnOieAd7zl4Whpq12hjKiN3q1od66IPSSlvGBSSX Y+fJ2eyrOkGulI97Qq4FiCR65bzR19v/rFtrJNSA3/5Wcz412aVXl3BqayFa8RLuQ5pGT6kQVWZ/O 3/kx8FIw==; In-Reply-To: <87ttnv23n8.fsf@neverwas.me> (J. P.'s message of "Tue, 02 Jan 2024 06:47:39 -0800") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277536 Archived-At: "J.P." writes: >>>From emacs -Q > > 1. M-: (setopt erc-keep-place-indicator-follow t) RET > M-x erc RET ... RET > > 2. In the server buffer, do M-x erc-keep-place-indicator-mode RET > > 3. Scroll "up" to hide the indicator but not so far that point moves > beyond `erc-insert-marker' > > 4. Switch away to another buffer and then back > > 5. Notice the indicator fails to update > > This happens because `keep-place-indicator' is a local module, and it > adds `erc--keep-place-indicator-on-window-buffer-change' to the hook > `window-buffer-change-functions' locally. But that function needs to run > in the buffer that's being switched to, which may not have the mode > enabled (and thus not have the hook member available). Subscribing to > the hook globally should fix the problem. There are also at least two > bugs affecting the integration between `keep-place-indicator' and > `keep-place'. The attached patch attempts to address these as well. This has been installed as: fad2d1e2acc * Use global window hook for erc-keep-place-indicator This bug is already closed.