Re: feature/android 2dcce30290d 1/2: Update Android port

Re: feature/android 2dcce30290d 1/2: Update Android port

[Robert Pluim]

>>>>> On Thu, 16 Feb 2023 10:57:39 -0500 (EST), Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:

    Po Lu> diff --git a/lisp/subr.el b/lisp/subr.el
    Po Lu> index f4f041ff32d..8e594fafa8c 100644
    Po Lu> --- a/lisp/subr.el
    Po Lu> +++ b/lisp/subr.el
    Po Lu> @@ -3424,6 +3424,9 @@ an error message."
    Po Lu>      (minibuffer-message "Wrong answer")
    Po Lu>      (sit-for 2)))
 
    Po Lu> +;; Defined in textconv.c.
    Po Lu> +(defvar overriding-text-conversion-style)
    Po Lu> +
    Po Lu>  (defun read-char-from-minibuffer (prompt &optional chars history)
    Po Lu>    "Read a character from the minibuffer, prompting for it with PROMPT.
    Po Lu>  Like `read-char', but uses the minibuffer to read and return a character.
    Po Lu> @@ -3438,7 +3441,15 @@ while calling this function, then pressing `help-char'
    Po Lu>  causes it to evaluate `help-form' and display the result.
    Po Lu>  There is no need to explicitly add `help-char' to CHARS;
    Po Lu>  `help-char' is bound automatically to `help-form-show'."
    Po Lu> -  (let* ((map (if (consp chars)
    Po Lu> +
    Po Lu> +  ;; If text conversion is enabled in this buffer, then it will only
    Po Lu> +  ;; be disabled the next time `force-mode-line-update' happens.
    Po Lu> +  (when (and overriding-text-conversion-style
    Po Lu> +             text-conversion-style)
    Po Lu> +    (force-mode-line-update))

`overriding-text-conversion-style' doesnʼt exist in builds that donʼt
compile textconv.c, such as MS-Windows. Perhap use `bound-and-true-p'?

Robert
-- 

Re: feature/android 2dcce30290d 1/2: Update Android port

[Po Lu]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Thu, 16 Feb 2023 10:57:39 -0500 (EST), Po Lu via Mailing list
>> for Emacs changes <emacs-diffs@gnu.org> said:
>
>     Po Lu> diff --git a/lisp/subr.el b/lisp/subr.el
>     Po Lu> index f4f041ff32d..8e594fafa8c 100644
>     Po Lu> --- a/lisp/subr.el
>     Po Lu> +++ b/lisp/subr.el
>     Po Lu> @@ -3424,6 +3424,9 @@ an error message."
>     Po Lu>      (minibuffer-message "Wrong answer")
>     Po Lu>      (sit-for 2)))
>  
>     Po Lu> +;; Defined in textconv.c.
>     Po Lu> +(defvar overriding-text-conversion-style)
>     Po Lu> +
>     Po Lu>  (defun read-char-from-minibuffer (prompt &optional chars history)
>     Po Lu>    "Read a character from the minibuffer, prompting for it with PROMPT.
>     Po Lu>  Like `read-char', but uses the minibuffer to read and return a character.
>     Po Lu> @@ -3438,7 +3441,15 @@ while calling this function, then pressing `help-char'
>     Po Lu>  causes it to evaluate `help-form' and display the result.
>     Po Lu>  There is no need to explicitly add `help-char' to CHARS;
>     Po Lu>  `help-char' is bound automatically to `help-form-show'."
>     Po Lu> -  (let* ((map (if (consp chars)
>     Po Lu> +
>     Po Lu> +  ;; If text conversion is enabled in this buffer, then it will only
>     Po Lu> +  ;; be disabled the next time `force-mode-line-update' happens.
>     Po Lu> +  (when (and overriding-text-conversion-style
>     Po Lu> +             text-conversion-style)
>     Po Lu> +    (force-mode-line-update))
>
> `overriding-text-conversion-style' doesnʼt exist in builds that donʼt
> compile textconv.c, such as MS-Windows. Perhap use `bound-and-true-p'?
>
> Robert

Thanks for the catch.