is the after-save-hook changed?

is the after-save-hook changed?

[Uwe Brauer via Emacs development discussions.]

Hi

I have used backup-each-save some years ago quite extensively.

Now I wanted, at least for some files, to use it again.

So I again started to use 
(require 'backup-each-save)
and locally in LaTeX file

--8<---------------cut here---------------start------------->8---
%%% Local Variables:
%%% mode: latex
%%% TeX-master: t
%%% vc-make-backup-files: t
%%% eval: (add-hook (make-local-variable 'after-save-hook) 'backup-each-save)
%%% End:
--8<---------------cut here---------------end--------------->8---





However describe variable after-save-hook shows me in this file

,----
| 
| after-save-hook is a variable defined in ‘files.el’.
| 
| Its value is (diff-hl-update t)
| Original value was nil
| Local in buffer test.tex; global value is (backup-each-save)
`----


So who is the culprit here?

Thanks and regards

Uwe Brauer 

Re: is the after-save-hook changed?

[Eli Zaretskii]

> Date: Wed, 10 Jan 2024 21:30:51 +0100
> From:  Uwe Brauer via "Emacs development discussions." <emacs-devel@gnu.org>
> 
> I have used backup-each-save some years ago quite extensively.
> 
> Now I wanted, at least for some files, to use it again.
> 
> So I again started to use 
> (require 'backup-each-save)
> and locally in LaTeX file
> 
> --8<---------------cut here---------------start------------->8---
> %%% Local Variables:
> %%% mode: latex
> %%% TeX-master: t
> %%% vc-make-backup-files: t
> %%% eval: (add-hook (make-local-variable 'after-save-hook) 'backup-each-save)
> %%% End:
> --8<---------------cut here---------------end--------------->8---
> 
> 
> 
> 
> 
> However describe variable after-save-hook shows me in this file
> 
> ,----
> | 
> | after-save-hook is a variable defined in ‘files.el’.
> | 
> | Its value is (diff-hl-update t)
> | Original value was nil
> | Local in buffer test.tex; global value is (backup-each-save)
> `----
> 
> 
> So who is the culprit here?

If you want a local hook setting, use the LOCAL argument of add-hook.

Re: is the after-save-hook changed?

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]



> If you want a local hook setting, use the LOCAL argument of add-hook.

Well 
this 
%%% eval: (add-hook (make-local-variable 'after-save-hook) 'backup-each-save)

Worked nicely in the past (and is still recommended in the documentation
of this package)

However I found out that now the syntax 

%%% eval: (add-hook (make-local-variable 'after-save-hook) 'backup-each-save nil t)

Makes it work again.

Maybe the doc-string of after-save-hook could say something about it?

-- 
I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel
I strongly condemn Putin's war of aggression against Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the EU and NATO membership of Ukraine. 


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: is the after-save-hook changed?

[Eli Zaretskii]

> From: Uwe Brauer <oub@mat.ucm.es>
> Cc: Uwe Brauer <oub@mat.ucm.es>, emacs-devel@gnu.org
> Date: Thu, 11 Jan 2024 07:55:01 +0100
> 
> > If you want a local hook setting, use the LOCAL argument of add-hook.
> 
> Well 
> this 
> %%% eval: (add-hook (make-local-variable 'after-save-hook) 'backup-each-save)
> 
> Worked nicely in the past (and is still recommended in the documentation
> of this package)
> 
> However I found out that now the syntax 
> 
> %%% eval: (add-hook (make-local-variable 'after-save-hook) 'backup-each-save nil t)
> 
> Makes it work again.
> 
> Maybe the doc-string of after-save-hook could say something about it?

There's nothing special about after-save-hook, the LOCAL argument is a
standard feature of add-hook and is documented in its doc string.

Btw, I don't understand why you use make-local-variable here.  I don't
think it's needed.

Re: is the after-save-hook changed?

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]



> There's nothing special about after-save-hook, the LOCAL argument is a
> standard feature of add-hook and is documented in its doc string.

> Btw, I don't understand why you use make-local-variable here.  I don't
> think it's needed.

(add-hook (make-local-variable 'after-save-hook) 'backup-each-save)

Worked, aeh, 10 years ago. So maybe I did not use this package since 10
years.


-- 
I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel
I strongly condemn Putin's war of aggression against Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the EU and NATO membership of Ukraine. 


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]