all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] Fix formatting
@ 2024-02-12 12:46 Ilya Chernyshov
  2024-02-12 13:06 ` Ihor Radchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Ilya Chernyshov @ 2024-02-12 12:46 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 130 bytes --]


Hi, just wanted the code to be more elisp style guide compliant, so here's
a patch that adds spaces before opening parentheses.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-formatting.patch --]
[-- Type: text/x-patch, Size: 5435 bytes --]

From 0d9b7ce6d5e83d7758566dab6a17642fdf4b9b73 Mon Sep 17 00:00:00 2001
From: Ilya Chernyshov <ichernyshovvv@gmail.com>
Date: Mon, 12 Feb 2024 18:33:29 +0600
Subject: [PATCH] Fix formatting

* lisp/ob-haskell.el (org-babel-interpret-haskell):
* lisp/ol-bibtex.el (org-bibtex-store-link):
* lisp/ol.el (org-link--fontify-links-to-this-file):
* lisp/org-agenda.el (org-agenda-open-link):
(org-agenda-reapply-filters):
* lisp/org-element.el (org-element-timestamp-interpreter):
* lisp/org-macs.el (org-buffer-list):
* lisp/org-pcomplete.el (pcomplete/org-mode/block-option/src):

Fix formatting.
---
 lisp/ob-haskell.el    | 2 +-
 lisp/ol-bibtex.el     | 2 +-
 lisp/ol.el            | 6 +++---
 lisp/org-agenda.el    | 4 ++--
 lisp/org-element.el   | 2 +-
 lisp/org-macs.el      | 2 +-
 lisp/org-pcomplete.el | 2 +-
 7 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/lisp/ob-haskell.el b/lisp/ob-haskell.el
index 00be6d52c..178e08424 100644
--- a/lisp/ob-haskell.el
+++ b/lisp/ob-haskell.el
@@ -188,7 +188,7 @@ This function should only be called by `org-babel-execute:haskell'."
                         (send-eoe)))
                       ;; We now display and capture the value.
                      (comint-with-output
-                      (lambda()
+                      (lambda ()
                         (send-txt-to-ghci "__LAST_VALUE_IMPROBABLE_NAME__\n")
                         (send-eoe))))))
              (results (mapcar #'org-strip-quotes
diff --git a/lisp/ol-bibtex.el b/lisp/ol-bibtex.el
index c5a950e2d..b7bfe3059 100644
--- a/lisp/ol-bibtex.el
+++ b/lisp/ol-bibtex.el
@@ -514,7 +514,7 @@ ARG, when non-nil, is a universal prefix argument.  See
 	   (link (concat "file:" (abbreviate-file-name buffer-file-name)
 			 "::" search))
 	   (entry (mapcar ; repair strings enclosed in "..." or {...}
-		   (lambda(c)
+		   (lambda (c)
 		     (if (string-match
 			  "^\\(?:{\\|\"\\)\\(.*\\)\\(?:}\\|\"\\)$" (cdr c))
 			 (cons (car c) (match-string 1 (cdr c))) c))
diff --git a/lisp/ol.el b/lisp/ol.el
index ef3e6addc..00bfaf13a 100644
--- a/lisp/ol.el
+++ b/lisp/ol.el
@@ -716,14 +716,14 @@ followed by another \"%[A-F0-9]{2}\" group."
 (defun org-link--fontify-links-to-this-file ()
   "Fontify links to the current file in `org-stored-links'."
   (let ((f (buffer-file-name)) a b)
-    (setq a (mapcar (lambda(l)
+    (setq a (mapcar (lambda (l)
 		      (let ((ll (car l)))
 			(when (and (string-match "^file:\\(.+\\)::" ll)
 				   (equal f (expand-file-name (match-string 1 ll))))
 			  ll)))
 		    org-stored-links))
     (when (featurep 'org-id)
-      (setq b (mapcar (lambda(l)
+      (setq b (mapcar (lambda (l)
 			(let ((ll (car l)))
 			  (when (and (string-match "^id:\\(.+\\)$" ll)
 				     (equal f (expand-file-name
@@ -731,7 +731,7 @@ followed by another \"%[A-F0-9]{2}\" group."
 						    (match-string 1 ll)) ""))))
 			    ll)))
 		      org-stored-links)))
-    (mapcar (lambda(l)
+    (mapcar (lambda (l)
 	      (put-text-property 0 (length l) 'face 'font-lock-comment-face l))
 	    (delq nil (append a b)))))
 
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 514359b62..121ac11f6 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -9469,7 +9469,7 @@ It also looks at the text of the entry itself."
 	 trg)
     (cond
      ((and buffer lk)
-      (mapcar (lambda(l)
+      (mapcar (lambda (l)
 		(with-current-buffer buffer
 		  (setq trg (and (string-match org-link-bracket-re l)
 				 (match-string 1 l)))
@@ -11000,7 +11000,7 @@ current HH:MM time."
 (defun org-agenda-reapply-filters ()
   "Re-apply all agenda filters."
   (mapcar
-   (lambda(f) (when (car f) (org-agenda-filter-apply (car f) (cadr f) t)))
+   (lambda (f) (when (car f) (org-agenda-filter-apply (car f) (cadr f) t)))
    `((,org-agenda-tag-filter tag)
      (,org-agenda-category-filter category)
      (,org-agenda-regexp-filter regexp)
diff --git a/lisp/org-element.el b/lisp/org-element.el
index e6df9743a..b8e0fc6dc 100644
--- a/lisp/org-element.el
+++ b/lisp/org-element.el
@@ -4383,7 +4383,7 @@ Assume point is at the beginning of the timestamp."
 
 (defun org-element-timestamp-interpreter (timestamp _)
   "Interpret TIMESTAMP object as Org syntax."
-  (let((type (org-element-property :type timestamp)))
+  (let ((type (org-element-property :type timestamp)))
     (if (member type '(active inactive inactive-range active-range))
         (let ((day-start (org-element-property :day-start timestamp))
               (month-start (org-element-property :month-start timestamp))
diff --git a/lisp/org-macs.el b/lisp/org-macs.el
index f14323d23..f713f4b8f 100644
--- a/lisp/org-macs.el
+++ b/lisp/org-macs.el
@@ -336,7 +336,7 @@ If EXCLUDE-TMP is non-nil, ignore temporary buffers."
 					      (buffer-name b)))))))))
     (delq nil
 	  (mapcar
-	   (lambda(b)
+	   (lambda (b)
 	     (if (and (funcall filter b)
 		      (or (not exclude-tmp)
 			  (not (string-match "tmp" (buffer-name b)))))
diff --git a/lisp/org-pcomplete.el b/lisp/org-pcomplete.el
index f1bc34966..f02c63e40 100644
--- a/lisp/org-pcomplete.el
+++ b/lisp/org-pcomplete.el
@@ -428,7 +428,7 @@ Complete a language in the first field, the header arguments and
 switches."
   (pcomplete-here
    (mapcar
-    (lambda(x) (symbol-name (nth 3 x)))
+    (lambda (x) (symbol-name (nth 3 x)))
     (cdr (car (cdr (memq :key-type (plist-get
 				    (symbol-plist
 				     'org-babel-load-languages)
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix formatting
  2024-02-12 12:46 [PATCH] Fix formatting Ilya Chernyshov
@ 2024-02-12 13:06 ` Ihor Radchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2024-02-12 13:06 UTC (permalink / raw)
  To: Ilya Chernyshov; +Cc: emacs-orgmode

Ilya Chernyshov <ichernyshovvv@gmail.com> writes:

> Hi, just wanted the code to be more elisp style guide compliant, so here's
> a patch that adds spaces before opening parentheses.

Sorry, but we do not accept whitespace-only commits because they may
create problems when searching git history. See
https://orgmode.org/worg/org-contribute.html#org594198c and
https://yhetil.org/emacs-devel/E1k8aul-0001mr-Mg@fencepost.gnu.org/

Canceled.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-12 13:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-12 12:46 [PATCH] Fix formatting Ilya Chernyshov
2024-02-12 13:06 ` Ihor Radchenko

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.