From: Po Lu <luangruo@yahoo.com>
To: Kai Ma <justksqsf@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] On the nasty "ghost key" problem on NS
Date: Fri, 04 Nov 2022 19:27:57 +0800 [thread overview]
Message-ID: <87sfizaria.fsf@yahoo.com> (raw)
In-Reply-To: <CE9B1601-3FAD-4FD4-9A63-A2E63B65629E@gmail.com> (Kai Ma's message of "Fri, 4 Nov 2022 19:04:48 +0800")
Kai Ma <justksqsf@gmail.com> writes:
> + owfi = waiting_for_input;
> + waiting_for_input = false;
> + if (WINDOWP (echo_area_window) && ! NILP (safe_call_inhibit_quit (0, Qns_in_echo_area)))
> win = XWINDOW (echo_area_window);
> else
> win = XWINDOW (FRAME_SELECTED_WINDOW (emacsframe));
> + waiting_for_input = owfi;
Please rename `owfi' to `was_waiting_for_input' or some other more
descriptive name. What happens if you just block input around safe_call
(0, Qns_in_echo_area), instead of making an extra function that passes a
magic flag to safe__call?
> +Lisp_Object
> +safe_call_inhibit_quit (ptrdiff_t nargs, Lisp_Object func, ...)
> +{
> + Lisp_Object retval;
> + va_list ap;
> +
> + va_start (ap, func);
> + retval = safe__call (true, nargs, func, ap);
> + va_end (ap);
> + return retval;
> +}
> +
This seems extraneous to me.
next prev parent reply other threads:[~2022-11-04 11:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 18:07 [PATCH] On the nasty "ghost key" problem on NS Kai Ma
2022-11-04 0:32 ` Po Lu
2022-11-04 6:28 ` Kai Ma
2022-11-04 7:16 ` Po Lu
2022-11-04 8:53 ` Kai Ma
2022-11-04 9:29 ` Po Lu
2022-11-04 11:04 ` Kai Ma
2022-11-04 11:27 ` Po Lu [this message]
2022-11-04 12:09 ` Kai Ma
2022-11-04 12:17 ` Po Lu
2022-11-04 15:09 ` Stefan Monnier
2022-11-05 0:43 ` Po Lu
2022-11-05 14:40 ` Stefan Monnier
2022-11-05 15:26 ` Kai Ma
2022-11-05 15:47 ` Stefan Monnier
2022-11-06 0:25 ` Po Lu
2022-11-10 11:59 ` Kai Ma
2022-11-10 12:25 ` Po Lu
2022-11-12 17:49 ` Stefan Monnier
2022-11-04 11:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfizaria.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=justksqsf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.