From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] On the nasty "ghost key" problem on NS Date: Fri, 04 Nov 2022 19:27:57 +0800 Message-ID: <87sfizaria.fsf@yahoo.com> References: <87leord0ei.fsf@yahoo.com> <87h6zfchpu.fsf@yahoo.com> <394D8618-AF36-44C4-BA64-7AFDFBBDC429@gmail.com> <878rkrcbkx.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31099"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Kai Ma Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 04 12:29:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqutQ-0007yt-BW for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Nov 2022 12:29:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqusf-0006Kn-EJ; Fri, 04 Nov 2022 07:29:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqus4-0006HR-3r for emacs-devel@gnu.org; Fri, 04 Nov 2022 07:28:28 -0400 Original-Received: from sonic310-23.consmr.mail.ne1.yahoo.com ([66.163.186.204]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqurw-0006vn-Ku for emacs-devel@gnu.org; Fri, 04 Nov 2022 07:28:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667561292; bh=j7Yusl1jGDmDf51AJP88WIfMQeO+w795gv0EmkmtBDY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=fDg1ebfpurWgBHDNtw4cdBprdJ1BS/c/R0XK7vfP35xY2HKHpiHMzjQVhqNSzORUS+zWwOatx7n6mHpkIT67fofEjVzW/IlXZWM9xCB0QqyXWD3XkI/vlkniLekYJjPVVO9LA8+GJQqLQvPYA5c92M1Ali9F75ozaCKUfx0Jjw4LHscL1kTXOoSAeAxzNeJh3Ujg1RNlAxBX1Id4rCsoblnHNf/wVnGse+BS8afr59kxYJ7Wt3/IqZeuVUzOu3z58pcj5hohXIkPmqoQmaEfzjaWpfZViuz/FduwGfAu83pj0aRkwhx5HuwVzDJFDrnuUFZkPddSaOI16JoFtzKFig== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667561292; bh=gYQS5kofQuQTK5vRg8Tu8LX+zrNpbZRR+S6NmGbyadp=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=OvBCrVkdTgf2m2x88dljGBy0lJKf+965n0ochgfuwmCT706WLTDtLFu+UkaiSwNgWlnjaOIKZtlKPbZSsUlbyAqi4HqA7anvowGbUkE2jPBTEEW272OzvsEYA0f8bG/Mmy1ULWlfKF2u9BV31WcTg4A2RSRg/g2DRfZt1V4UscLGKuVYD8OPkQ5QSmq/039xbaV5FDxZiVHoMXObQV4M0dHqy1qgEanQMOsS2c8Pq+8SmqgXSxUpTrdCBCg/bCAhY6zGl46a1haIRm2lhJzlbERA6sgj2e+e9c2ank4nUAjyZ+q1dco8qimXYwdt09jFqJk33/NUjLe7XyhDC5p13g== X-YMail-OSG: GkBu.38VM1m4I3qiez_WRi3W2eWaaw9LAPCc6zPDA3tAi6y.5_78bJ4gSHnZKJn MRcEsnwJPFTB23H72bha0C2KOrcm5aWJNQmAUA3tHTFNtdRYH9CTt0yc7xDRx._EK2jegPXq.tcF 2hjOlQskyNn3tQfrTo9d.GWdXtywbhcDKSj7glcAB4Snsw2Ey_XDbXNjbCQORW7DXgnL4APMYgxQ _rFr0ucdEQwFWRlWntysCEm.Zz5vlfN2jbBUOLofgJ7cYzLroNQaBdUkqWDALeNEo6DKcKtk4NjH 10dJH6JsctoeYlkKS0CmGKuQJmxzffH_wjVmMiI7LjdSYO3Q3WvvHlSWusvkpn4sFfyvPd_lFkgR 8EiFRPkLVrGQnuKsFUts3h7Bs34q99xYcq3wvVe2XIle4vmFITcoWtltYkUcDD4.._9ml4jOW6CX NmgghcnNBFAulxeikYQhD1VKQ1WCxpTrE8vh9tn7OWtW36lNjYnYNkxbvjFXxmNMfqjbeBmqF71v zMsTn0BqlVi1glwYa1K6jEs28MBZ4l9835gG1w_wZOENm.CWdzXov_xJiRbn02hDYNQoPwhZ5ObO WltFrQReqWR06.s8APB9b0Mj78Cvf28fayMNqLVpLFwLSBmcm.NBNXvJPuHnck6MN6IEpS.SQcQ8 NAjRluB6YSnQnd8Qv.xiacUlLCqmDEclnFftyk0is6WuG.u9591mIHDiBM_ascLVz3m7UI8JMrE9 uYeDuKhOyXpG8Hz.PkkezGiWZsnw3_lQTdwr37hWj2e.cE_gGGJM8H9rMSFxhYWYyC_H3feq6w6C OL48NsQc_5HBCuyiHOSrujlRU5whoKp9hcg4hzDPY8 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Fri, 4 Nov 2022 11:28:12 +0000 Original-Received: by hermes--production-sg3-6c8895b545-zc8w5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID aed0fa007bea8f8157ffdcc2e0fa8e7a; Fri, 04 Nov 2022 11:28:06 +0000 (UTC) In-Reply-To: (Kai Ma's message of "Fri, 4 Nov 2022 19:04:48 +0800") X-Mailer: WebService/1.1.20783 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.186.204; envelope-from=luangruo@yahoo.com; helo=sonic310-23.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299121 Archived-At: Kai Ma writes: > + owfi = waiting_for_input; > + waiting_for_input = false; > + if (WINDOWP (echo_area_window) && ! NILP (safe_call_inhibit_quit (0, Qns_in_echo_area))) > win = XWINDOW (echo_area_window); > else > win = XWINDOW (FRAME_SELECTED_WINDOW (emacsframe)); > + waiting_for_input = owfi; Please rename `owfi' to `was_waiting_for_input' or some other more descriptive name. What happens if you just block input around safe_call (0, Qns_in_echo_area), instead of making an extra function that passes a magic flag to safe__call? > +Lisp_Object > +safe_call_inhibit_quit (ptrdiff_t nargs, Lisp_Object func, ...) > +{ > + Lisp_Object retval; > + va_list ap; > + > + va_start (ap, func); > + retval = safe__call (true, nargs, func, ap); > + va_end (ap); > + return retval; > +} > + This seems extraneous to me.