* Patch ok for release branch? [not found] <87sfggegc7.fsf.ref@yahoo.com> @ 2023-01-12 0:39 ` Po Lu 2023-01-12 7:45 ` Eli Zaretskii 0 siblings, 1 reply; 3+ messages in thread From: Po Lu @ 2023-01-12 0:39 UTC (permalink / raw) To: emacs-devel Is this OK for Emacs 29? It fixes a bug where the input method popup appears at the wrong location when a margin is enabled. diff --git a/src/pgtkterm.c b/src/pgtkterm.c index 13f6c6c3c4d..9190649f414 100644 --- a/src/pgtkterm.c +++ b/src/pgtkterm.c @@ -2959,7 +2959,8 @@ pgtk_draw_window_cursor (struct window *w, struct glyph_row *glyph_row, int x, if (w == XWINDOW (f->selected_window)) { int frame_x = (WINDOW_TO_FRAME_PIXEL_X (w, x) - + WINDOW_LEFT_FRINGE_WIDTH (w)); + + WINDOW_LEFT_FRINGE_WIDTH (w) + + WINDOW_LEFT_MARGIN_WIDTH (w)); int frame_y = WINDOW_TO_FRAME_PIXEL_Y (w, y); pgtk_im_set_cursor_location (f, frame_x, frame_y, w->phys_cursor_width, ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: Patch ok for release branch? 2023-01-12 0:39 ` Patch ok for release branch? Po Lu @ 2023-01-12 7:45 ` Eli Zaretskii 2023-01-12 10:31 ` Po Lu 0 siblings, 1 reply; 3+ messages in thread From: Eli Zaretskii @ 2023-01-12 7:45 UTC (permalink / raw) To: Po Lu; +Cc: emacs-devel > From: Po Lu <luangruo@yahoo.com> > Date: Thu, 12 Jan 2023 08:39:36 +0800 > > Is this OK for Emacs 29? It fixes a bug where the input method popup > appears at the wrong location when a margin is enabled. Yes, OK. Thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch ok for release branch? 2023-01-12 7:45 ` Eli Zaretskii @ 2023-01-12 10:31 ` Po Lu 0 siblings, 0 replies; 3+ messages in thread From: Po Lu @ 2023-01-12 10:31 UTC (permalink / raw) To: Eli Zaretskii; +Cc: emacs-devel Eli Zaretskii <eliz@gnu.org> writes: > Yes, OK. Thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-12 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87sfggegc7.fsf.ref@yahoo.com>
2023-01-12 0:39 ` Patch ok for release branch? Po Lu
2023-01-12 7:45 ` Eli Zaretskii
2023-01-12 10:31 ` Po Lu
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.