From: Michael Heerdegen <michael_heerdegen@web.de>
To: 56679@debbugs.gnu.org
Cc: yet@ego.team
Subject: bug#56679: 28.1; whitespace-style cannot be configured for diff-mode via hook
Date: Sat, 23 Jul 2022 02:15:39 +0200 [thread overview]
Message-ID: <87r12c8z10.fsf@web.de> (raw)
In-Reply-To: <m2r12e1q2u.fsf@ego.team> (YE via's message of "Thu, 21 Jul 2022 17:46:17 +0300")
YE via "Bug reports for GNU Emacs, the Swiss army knife of text editors"
<bug-gnu-emacs@gnu.org> writes:
> Or maybe adding a defcustom 'diff-whitespace-style' would be a proper
> solution here?
Since `diff-setup-whitespace' unconditionally sets whitespace-style from
a hardcoded value, this is the natural fix.
> I started working on such a patch but stuck disliking the probable
> need in the 'whitespace-style' large ':type' definition duplication.
I think you don't need a duplication. You can reuse an existing type
definition by looking up the `custom-type` symbol property of an already
defined option. See e.g. "lisp/eshell/em-cmpl.el" for a few example
definitions.
Michael.
next prev parent reply other threads:[~2022-07-23 0:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 14:46 bug#56679: 28.1; whitespace-style cannot be configured for diff-mode via hook YE via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-23 0:15 ` Michael Heerdegen [this message]
2022-07-24 7:49 ` bug#56679: 28.1; [PATCH] " YE via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-24 9:02 ` Lars Ingebrigtsen
2022-07-24 9:08 ` Eli Zaretskii
2022-07-25 2:38 ` Michael Heerdegen
2022-07-25 11:07 ` Eli Zaretskii
2022-07-26 3:59 ` Michael Heerdegen
2022-07-26 12:27 ` YE via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-27 9:52 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r12c8z10.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=56679@debbugs.gnu.org \
--cc=yet@ego.team \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.