From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#56679: 28.1; whitespace-style cannot be configured for diff-mode via hook Date: Sat, 23 Jul 2022 02:15:39 +0200 Message-ID: <87r12c8z10.fsf@web.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7931"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: yet@ego.team To: 56679@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 23 02:16:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oF2oV-0001xA-J6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jul 2022 02:16:11 +0200 Original-Received: from localhost ([::1]:40896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oF2oU-0001Jb-6J for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Jul 2022 20:16:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oF2oM-0001JT-CB for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2022 20:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53021) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oF2oM-0006GV-3I for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2022 20:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oF2oL-00074S-UQ for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2022 20:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jul 2022 00:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56679 X-GNU-PR-Package: emacs X-Debbugs-Original-To: YE via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: YE , 56679@debbugs.gnu.org Original-Received: via spool by 56679-submit@debbugs.gnu.org id=B56679.165853535627159 (code B ref 56679); Sat, 23 Jul 2022 00:16:01 +0000 Original-Received: (at 56679) by debbugs.gnu.org; 23 Jul 2022 00:15:56 +0000 Original-Received: from localhost ([127.0.0.1]:42769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oF2oF-00073y-Ma for submit@debbugs.gnu.org; Fri, 22 Jul 2022 20:15:55 -0400 Original-Received: from mout.web.de ([212.227.15.3]:47653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oF2oA-00073h-4Q for 56679@debbugs.gnu.org; Fri, 22 Jul 2022 20:15:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1658535340; bh=hn7rIET5B0GVJY1XVifwn5wRqkrSrvgE26DUkGjjivs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=P3H16WI715eZR4cjN3XCYqG10BVDdjAdZ6Qh8b2dDJi0x+ol4gra4IYdjtCVlsLN1 yVAvSAHsSpA8oJQqrc/mtvIvc/oeOqKBHogUil32H+2mErIvIYxMc/F/4FtUuZmPT6 rFVYp5Bi0O5ZKrZpqNudy0A+0UYlDM3Mwzjnqggk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MODiX-1nqc4L0X3R-00Oc8C; Sat, 23 Jul 2022 02:15:40 +0200 In-Reply-To: (YE via's message of "Thu, 21 Jul 2022 17:46:17 +0300") X-Provags-ID: V03:K1:RNLL2glkrGW4+m7UbVy023AYepMikhVvSApaJl+Mi3e6s+jxjBF PARmljrixFDreexebvkeIDBQYnAtVUibYNSGR6XGIdYXtRF3DyAiFvAL35so4IiMSpQsNQl PAJXtTRTVA/3uWRroA/MHqqG5ZukiARWrxKqz4nLtkVmfnP/k+pFUnzgmwZyD3ZlVTVtE9c H532TObBEU1ZRSuMnxvQg== X-UI-Out-Filterresults: notjunk:1;V03:K0:wYkZFNx5Hwc=:0UL7BKS/IiOzNvAeQv8Ewh k877KbIztYR61bmkjaKU1qp/QxPmp3sS/FrQa6/wCfRfd6q/BeHhAoETyAXb1+ARM5sn8wfQ1 spFNRv5sXRJgt01FxvWihaV8OTswM4GRNOTYH3kpTYS16qtdFt/bxok2c6zvxstX49ZjMxFdF +BfUZ8eNb51ZsEdwA7Z0MB98MMcXF+lt/S33SEmZm64F9NKJyglOWwLTuXH/bgDC9kdzmKAo7 j5fWP6txXQ9i2432BtcdCfNwkrytmAjheAVTF0gXEGSN6zOnmCCJA8iL2QVFNrC1GP2lYeuaO 4IMgfkUSmioFTJs76j225qiDjK3UUmSxZvC6GAyooRezSpIQFHf80+fC0+YE9YkmqVyR+P0oj CNs7SuzKm1uMetJwMqpDAODXb8DpG/LYA81nH+E27etIzD0YVdlJ1t947Uq0SD2XQAdc6EwNf jFniReF6M/o1LVNuYO1/prWIBmz7HUc6dwwNL1kA2TgQOYLkNEj0jmaTZoQxSOMjOyrQEnGie RmOm0eyDjEmrFCJavIYByhesQFyUwbDoARNMYIBwXIIpvq6ATyt208CZJTKiis+Tr06bLMbDD yX66WTbo9dJqZXOjEqwpFlTADlOS7qvCe6Br09hvhFIMD1afDRldimdYi8aZZHDX39yUsAdQF yJo/P30AKu9c5k9POuVBtKpdfWiI8ChG0IiiijvEFlTl2zwbk91Bli7Ojy9eoj8mbMaXCavUt mj5wOGaRbtjL4MveZ53EOQjMQsuAXDRdqd+LQuerTIG60ambU0i6I2qvBvanYVv6I6ckA9Zi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237657 Archived-At: YE via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Or maybe adding a defcustom 'diff-whitespace-style' would be a proper > solution here? Since `diff-setup-whitespace' unconditionally sets whitespace-style from a hardcoded value, this is the natural fix. > I started working on such a patch but stuck disliking the probable > need in the 'whitespace-style' large ':type' definition duplication. I think you don't need a duplication. You can reuse an existing type definition by looking up the `custom-type` symbol property of an already defined option. See e.g. "lisp/eshell/em-cmpl.el" for a few example definitions. Michael.