From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: sbaugh@catern.com, Eli Zaretskii <eliz@gnu.org>, 62164@debbugs.gnu.org
Subject: bug#62164: 29.0.60; ediff behaves poorly by default on tiling window managers
Date: Tue, 06 Jun 2023 07:51:44 +0800 [thread overview]
Message-ID: <87r0qpjwmn.fsf@yahoo.com> (raw)
In-Reply-To: <ierzg5d8tex.fsf@janestreet.com> (Spencer Baugh's message of "Mon, 05 Jun 2023 17:56:38 -0400")
Spencer Baugh <sbaugh@janestreet.com> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>>> Cc: Po Lu <luangruo@yahoo.com>, 62164@debbugs.gnu.org
>>> From: Spencer Baugh <sbaugh@janestreet.com>
>>> Date: Tue, 09 May 2023 14:27:11 -0400
>>>
>>> +(defcustom ediff-x-utility-control-frame nil
>>> + "If non-nil, the control frame is a utility window under X.
>>> +
>>> +This is useful in tiling window managers, where this will cause
>>> +the control frame to be floating rather than tiled. It should be
>>> +harmless on other well-behaved window managers."
>>
>> If this option causes the control frame to be floating rather than
>> tiled, the name of the option should reflect that. Using "utility" in
>> the name of the variable makes the option less self-explanatory,
>> because that technical terms is not relevant on the user level.
>>
>> Thanks.
>
> Agreed. Revised patch attached:
>
> From 8725b7376b3e6ddaaa4389d363bd9da56bf3eedb Mon Sep 17 00:00:00 2001
> From: Spencer Baugh <sbaugh@janestreet.com>
> Date: Tue, 9 May 2023 14:22:29 -0400
> Subject: [PATCH] Allow setting the ediff control frame as a utility window
> under X
>
> This is a step in the direction of making ediff behave better by
> default under tiling window managers and fixing bug#62164.
>
> * lisp/vc/ediff-wind.el (ediff-x-utility-control-frame): Add
> defcustom.
> (ediff-frame-make-utility, ediff-setup-control-frame): Allow setting
> the control frame up as a utility window under X. (bug#62164)
> ---
> lisp/vc/ediff-wind.el | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/lisp/vc/ediff-wind.el b/lisp/vc/ediff-wind.el
> index eb903f093f9..e50df599a98 100644
> --- a/lisp/vc/ediff-wind.el
> +++ b/lisp/vc/ediff-wind.el
> @@ -69,6 +69,16 @@ ediff-window-setup-function
> (function :tag "Other function"))
> :version "24.3")
>
> +(defcustom ediff-x-floating-control-frame nil
I don't think this is correct. Ordering the control frame above other
windows is one policy taken towards utility windows, but other window
managers may behave differently (by placing the utility window at a
fixed position, for instance.)
The name of this variable should not depend on the behavior of the
window manager.
next prev parent reply other threads:[~2023-06-05 23:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 16:44 bug#62164: 29.0.60; ediff behaves poorly by default on tiling window managers Spencer Baugh
2023-03-14 0:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-14 1:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-16 15:07 ` Spencer Baugh
2023-03-17 1:56 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-02 1:53 ` sbaugh
2023-04-02 5:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-02 11:33 ` sbaugh
2023-05-09 18:27 ` Spencer Baugh
2023-05-09 19:15 ` Eli Zaretskii
2023-06-05 21:56 ` Spencer Baugh
2023-06-05 23:51 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-06-06 11:29 ` Eli Zaretskii
2023-06-28 1:13 ` Spencer Baugh
2023-06-28 1:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-28 11:56 ` Eli Zaretskii
2023-06-28 12:55 ` Spencer Baugh
2023-06-28 13:40 ` Robert Pluim
2023-07-03 19:21 ` sbaugh
2023-07-06 7:51 ` Eli Zaretskii
2023-03-14 3:06 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-14 13:13 ` Phil Sainty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0qpjwmn.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=62164@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
--cc=sbaugh@catern.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.