all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: sbaugh@catern.com
Cc: luangruo@yahoo.com, sbaugh@janestreet.com, rpluim@gmail.com,
	62164-done@debbugs.gnu.org
Subject: bug#62164: 29.0.60; ediff behaves poorly by default on tiling window managers
Date: Thu, 06 Jul 2023 10:51:15 +0300	[thread overview]
Message-ID: <83fs61iiks.fsf@gnu.org> (raw)
In-Reply-To: <87edloreb3.fsf@catern.com> (sbaugh@catern.com)

> From: sbaugh@catern.com
> Date: Mon, 03 Jul 2023 19:21:53 +0000 (UTC)
> Cc: Spencer Baugh <sbaugh@janestreet.com>, luangruo@yahoo.com, Eli Zaretskii
> 	<eliz@gnu.org>, 62164@debbugs.gnu.org
> 
> > I think the new user option warrants an entry in etc/NEWS
> 
> Added, patch at the end.
> 
> >     Spencer> ---
> >     Spencer>  lisp/vc/ediff-wind.el | 22 ++++++++++++++++++++++
> >     Spencer>  1 file changed, 22 insertions(+)
> >
> >     Spencer> diff --git a/lisp/vc/ediff-wind.el b/lisp/vc/ediff-wind.el
> >     Spencer> index eb903f093f9..74e0e1f9b9f 100644
> >     Spencer> --- a/lisp/vc/ediff-wind.el
> >     Spencer> +++ b/lisp/vc/ediff-wind.el
> >     Spencer> @@ -69,6 +69,16 @@ ediff-window-setup-function
> >     Spencer>  		 (function :tag "Other function"))
> >     Spencer>    :version "24.3")
> >  
> >     Spencer> +(defcustom ediff-floating-control-frame nil
> >     Spencer> +  "If not-nil, try making the control frame be floating rather than tiled.
> >     Spencer> +
> >
> > Style: the description of the option should state the action that
> > follows from a non-nil value:
> >
> > "Whether to request a floating control frame rather than a tiled one."
> 
> No, this is correct style, see (info "(elisp) Documentation Tips")
> 
>    • The documentation string for a variable that is a yes-or-no flag
>      should start with words such as “Non-nil means”, to make it clear
>      that all non-‘nil’ values are equivalent and indicate explicitly
>      what ‘nil’ and non-‘nil’ mean.

Thanks, installed on master, and closing the bug.





  reply	other threads:[~2023-07-06  7:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 16:44 bug#62164: 29.0.60; ediff behaves poorly by default on tiling window managers Spencer Baugh
2023-03-14  0:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-14  1:00   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-16 15:07     ` Spencer Baugh
2023-03-17  1:56       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-02  1:53         ` sbaugh
2023-04-02  5:55           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-02 11:33             ` sbaugh
2023-05-09 18:27               ` Spencer Baugh
2023-05-09 19:15                 ` Eli Zaretskii
2023-06-05 21:56                   ` Spencer Baugh
2023-06-05 23:51                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-06 11:29                     ` Eli Zaretskii
2023-06-28  1:13                       ` Spencer Baugh
2023-06-28  1:25                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-28 11:56                         ` Eli Zaretskii
2023-06-28 12:55                           ` Spencer Baugh
2023-06-28 13:40                             ` Robert Pluim
2023-07-03 19:21                               ` sbaugh
2023-07-06  7:51                                 ` Eli Zaretskii [this message]
2023-03-14  3:06   ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-14 13:13 ` Phil Sainty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fs61iiks.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=62164-done@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=rpluim@gmail.com \
    --cc=sbaugh@catern.com \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.