From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: vojtech@balak.me, 62528@debbugs.gnu.org
Subject: bug#62528: 28.2; Emacsclient doesn't use COLORTERM
Date: Thu, 30 Mar 2023 11:41:42 +0200 [thread overview]
Message-ID: <87o7oalgo9.fsf@gmail.com> (raw)
In-Reply-To: <83h6u260r4.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 30 Mar 2023 12:34:39 +0300")
>>>>> On Thu, 30 Mar 2023 12:34:39 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Vojtěch Balák <vojtech@balak.me>,
>> 62528@debbugs.gnu.org
>> Date: Thu, 30 Mar 2023 10:59:32 +0200
>>
>> >>>>> On Thu, 30 Mar 2023 09:49:56 +0200, Vojtěch Balák <vojtech@balak.me> said:
>>
>> >> COLORTERM should be in the environment of emacs when it starts, not in
>> >> the environment of emacsclient.
>>
>> Thatʼs because we look it up using `getenv' in init_tty. If we used
>> `egetenv' instead, then we could honour the value of "COLORTERM" sent
>> by emacsclient.
Eli> But egetenv would be wrong here, because it looks in
Eli> process-environment.
Well yes, thatʼs the whole point
Eli> This is _exactly_ the issue here: emacsclient puts the environment of
Eli> the parent shell into process-environment, so that it could be
Eli> inherited by sub-processes, but Emacs itself should _not_ be sensitive
Eli> to the environment it prepares for sub-processes.
Normally Iʼd agree with you, but this a grey area: weʼre creating a
new frame, so having its characteristics depend on information sent by
emacsclient makes sense, especially since server.el already goes to
the trouble of ensuring that emacsclientʼs value of COLORTERM is
inherited.
Would you accept a compromise where we check `getenv', and if the
value is empty, check `egetenv'?
Robert
--
next prev parent reply other threads:[~2023-03-30 9:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 15:06 bug#62528: 28.2; Emacsclient doesn't use COLORTERM Vojtěch Balák
2023-03-29 17:21 ` Eli Zaretskii
2023-03-29 18:42 ` Vojtěch Balák
2023-03-29 18:48 ` Eli Zaretskii
2023-03-30 7:49 ` Vojtěch Balák
2023-03-30 8:51 ` Eli Zaretskii
2023-03-30 8:59 ` Robert Pluim
2023-03-30 9:34 ` Eli Zaretskii
2023-03-30 9:41 ` Robert Pluim [this message]
2023-03-30 10:36 ` Eli Zaretskii
2023-03-30 12:11 ` Robert Pluim
2023-03-30 14:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7oalgo9.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=62528@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=vojtech@balak.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.