From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#62528: 28.2; Emacsclient doesn't use COLORTERM Date: Thu, 30 Mar 2023 11:41:42 +0200 Message-ID: <87o7oalgo9.fsf@gmail.com> References: <998d09cc-292e-4c14-a14c-2d1ad0e3ab34@betaapp.fastmail.com> <837cuz79sy.fsf@gnu.org> <834jq375sj.fsf@gnu.org> <87wn2ylimj.fsf@gmail.com> <83h6u260r4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33634"; mail-complaints-to="usenet@ciao.gmane.io" Cc: vojtech@balak.me, 62528@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 30 11:42:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phonL-0008aI-41 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Mar 2023 11:42:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phonE-0003lZ-Dn; Thu, 30 Mar 2023 05:42:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phonC-0003l1-Ji for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2023 05:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phonC-0003Nm-CT for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2023 05:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1phonC-00043d-7b for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2023 05:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Mar 2023 09:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62528 X-GNU-PR-Package: emacs Original-Received: via spool by 62528-submit@debbugs.gnu.org id=B62528.168016931215573 (code B ref 62528); Thu, 30 Mar 2023 09:42:02 +0000 Original-Received: (at 62528) by debbugs.gnu.org; 30 Mar 2023 09:41:52 +0000 Original-Received: from localhost ([127.0.0.1]:55806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phon1-000436-J8 for submit@debbugs.gnu.org; Thu, 30 Mar 2023 05:41:51 -0400 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:42726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phomz-00042r-Rv for 62528@debbugs.gnu.org; Thu, 30 Mar 2023 05:41:50 -0400 Original-Received: by mail-wr1-f50.google.com with SMTP id e18so18396455wra.9 for <62528@debbugs.gnu.org>; Thu, 30 Mar 2023 02:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680169303; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=U2Zy6lKfeBFixT64qlaPD1F0YliXS1lA8Jq5IjjXhUE=; b=ajxH3lo7T+Dw4p0ajytxxg+FUp0SFTp5Uqa29+Iij6sRBc9WEHjuWV5giQnxh431Ml qF19pGcw0aAI4BYhywMl9KaqyypRW9EIJ5OBsEetR2f1anvHj4LY2lqbWaVv4NkG+E8h TeYMFvBBSYIyWYa5W8wgJnBRDl3lbxweWMxB0HExMIr6uyCLou9PzFppDmwkffLAzvem MjE1Rnt3pUDQ5nkYZNTiHFdABEBaCk9jkiLm/6Fkq1rfmUs9sTGNcSujbIHNedSUBRUt UJSjzb0rGxo7xQNSqyK9mj825pDIQpvISla3XPoyxHiaMgmYc2SQ0EuWw9TqX3Lldbbh VjHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680169303; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U2Zy6lKfeBFixT64qlaPD1F0YliXS1lA8Jq5IjjXhUE=; b=IKG/mQcwqSGYNL5LcUU9ltV785S2uO71uhnq/zcSxHMjbko41IP5qb37JgDiIenVGs 09hS+6zpjk649Sl6wBkBXRvjzJlKZ3O2JBsdM3beyoC1wBvGU8jyCrGmVTP2Ch/XMPLs lhM4O1we5VIc9/rsDOmi5QoLgtKDn9rUD9VUyM8iOdDhDggFJz9WdAPn26x1zlPR4ZEv xzd4RreLaMTxhw9fBC/Du+MtYNqWO1raWamlqyrzOuvamoLYf2k2UCwUh3x6JqgxV3ds UUt3qsGHg7OWid1efMxJWIs0KgPnMNoglwC/KbbzdT2enaUbjhf0fsJ6ObdiDq2gnk26 P9lA== X-Gm-Message-State: AAQBX9cYkW0ZIj4bzGWdRfeU3FUPXYN0tLcJndRq0rtnah57kX2BXKyJ NY9TiWmYDw7wG7Yj63Sha2Kla8d7qXc= X-Google-Smtp-Source: AKy350Z9Id6DVW3fWqd4fCCosEUmn0Ngxl2jpah2XYvs8rneR4mLkp61TQqTv08hwhyH1zwpwa0WHQ== X-Received: by 2002:adf:fd81:0:b0:2c8:9ab8:85f9 with SMTP id d1-20020adffd81000000b002c89ab885f9mr21339442wrr.40.1680169303485; Thu, 30 Mar 2023 02:41:43 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id e7-20020a5d5307000000b002c5a1bd5280sm32383114wrv.95.2023.03.30.02.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 02:41:43 -0700 (PDT) In-Reply-To: <83h6u260r4.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 30 Mar 2023 12:34:39 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258913 Archived-At: >>>>> On Thu, 30 Mar 2023 12:34:39 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Vojt=C4=9Bch Bal=C3=A1k , >> 62528@debbugs.gnu.org >> Date: Thu, 30 Mar 2023 10:59:32 +0200 >>=20 >> >>>>> On Thu, 30 Mar 2023 09:49:56 +0200, Vojt=C4=9Bch Bal=C3=A1k said: >>=20 >> >> COLORTERM should be in the environment of emacs when it starts, n= ot in >> >> the environment of emacsclient. >>=20 >> That=CA=BCs because we look it up using `getenv' in init_tty. If we = used >> `egetenv' instead, then we could honour the value of "COLORTERM" sent >> by emacsclient. Eli> But egetenv would be wrong here, because it looks in Eli> process-environment. Well yes, that=CA=BCs the whole point Eli> This is _exactly_ the issue here: emacsclient puts the environment= of Eli> the parent shell into process-environment, so that it could be Eli> inherited by sub-processes, but Emacs itself should _not_ be sensi= tive Eli> to the environment it prepares for sub-processes. Normally I=CA=BCd agree with you, but this a grey area: we=CA=BCre creating= a new frame, so having its characteristics depend on information sent by emacsclient makes sense, especially since server.el already goes to the trouble of ensuring that emacsclient=CA=BCs value of COLORTERM is inherited. Would you accept a compromise where we check `getenv', and if the value is empty, check `egetenv'? Robert --=20