From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, gregory@heytings.org, juri@linkov.net
Subject: Re: emacs-29 9ecebcdded: * lisp/simple.el (next-completion): Handle first completion specially.
Date: Fri, 13 Jan 2023 14:57:08 +0100 [thread overview]
Message-ID: <87k01qedvv.fsf@gmail.com> (raw)
In-Reply-To: <83bkn2a733.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Jan 2023 15:37:36 +0200")
>>>>> On Fri, 13 Jan 2023 15:37:36 +0200, Eli Zaretskii <eliz@gnu.org> said:
Eli> Fixed. It's a clear case of a test that adapted the results to what
Eli> the code produced, not to the desired/expected value.
Itʼs fixed, but Iʼll admit that I donʼt understand why:
(should (equal "aa" (get-text-property (point) 'completion--string)))
(next-completion 3)
(should (equal "ac" (get-text-property (point) 'completion--string)))
(previous-completion 2)
(should (equal "aa" (get-text-property (point) 'completion--string)))
So we go forward 3 from "aa" to get to "ac", but then to get back to
"aa" itʼs back 2?
Robert
--
next prev parent reply other threads:[~2023-01-13 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167354569613.4370.3805904095626587994@vcs2.savannah.gnu.org>
[not found] ` <20230112174816.7E88BC00A7F@vcs2.savannah.gnu.org>
2023-01-13 12:49 ` emacs-29 9ecebcdded: * lisp/simple.el (next-completion): Handle first completion specially Robert Pluim
2023-01-13 13:37 ` Eli Zaretskii
2023-01-13 13:57 ` Robert Pluim [this message]
2023-01-13 14:57 ` Eli Zaretskii
2023-01-14 17:17 ` Juri Linkov
2023-01-14 18:57 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k01qedvv.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gregory@heytings.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.