From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 9ecebcdded: * lisp/simple.el (next-completion): Handle first completion specially. Date: Fri, 13 Jan 2023 14:57:08 +0100 Message-ID: <87k01qedvv.fsf@gmail.com> References: <167354569613.4370.3805904095626587994@vcs2.savannah.gnu.org> <20230112174816.7E88BC00A7F@vcs2.savannah.gnu.org> <87o7r2eh04.fsf@gmail.com> <83bkn2a733.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5583"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, gregory@heytings.org, juri@linkov.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 13 14:59:18 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pGKaT-0000rW-Is for ged-emacs-devel@m.gmane-mx.org; Fri, 13 Jan 2023 14:59:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGKYZ-0002Ei-2x; Fri, 13 Jan 2023 08:57:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGKYV-0002CC-MG for emacs-devel@gnu.org; Fri, 13 Jan 2023 08:57:15 -0500 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pGKYS-0000QM-ED; Fri, 13 Jan 2023 08:57:14 -0500 Original-Received: by mail-wr1-x436.google.com with SMTP id co23so21159829wrb.4; Fri, 13 Jan 2023 05:57:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=oVBIr5OB160lniGzeBJoDhVBKOsINYTg2bttz/ZS2/c=; b=VuF5OXEvJUIg2tx0XzTYJVEsuq8PZVdDYZHKtafuCZD+JDuG6O3oBS0KLIQOiJjRNW ykf+PyTtBajamw7CI/GGq5IkKsE1pgaPPszQnuXuk8avZcaC2hdifIxz4OxyQ/swjSUp b6WdfzqF5vU37vK+BcYb6UoHzmxkgZRHwF6657Xaxm12pcV/GtoqfGMPLsZw+xl8ZKye 1r9h4URYTqC2V3CR1ZyS5gb4PbXyDvvzlvCaBKkWlTe7WuGeRmrwecODmFnwOvs23pVE 4mG5DWPfW12RHEblwTNeZkt8/XFYANJ3lYmC/vncraGz6qh+vPiF16Mt4Nb+woaYoq6y cbBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oVBIr5OB160lniGzeBJoDhVBKOsINYTg2bttz/ZS2/c=; b=5pG83JQqY/RRJtZWine4Xvzs6JJk2PNLZlJhB2bDgWyADRnF/IWadpBHtL8dQrP/z5 F1rMxcCENfCsaaofP8iJ3MX55I7+nMnF+O57NoUL+waUXQTKOBnz4Ns8dMyi6BwP25V5 WsYQjgBL4Ypt4U9qGNIEfkYQ+rtw24goKsBQ0a3FCNcxCeeZKrmdDRIAHB77BuaVgQ/A +7sZfH3QenZVgG6hzKqPJAiFPY3roQHXSO/2qk7q+fllTPoN8FxifXUpO0qGKVj1TBxu oPAAt7hqy9t/kWNsVXJnDSENXjmnww55fksqs79Pexh59kbJhaO49+XpOxLkAjD7lZiN EMEg== X-Gm-Message-State: AFqh2kqzfwaOsCc1t+8XL8lOF7xtLmo+C0VvO32uidPiNTQy6rA9tM8i vJa9hE8iflxp5U6T7NrSucQ= X-Google-Smtp-Source: AMrXdXunB8QmXMIA3ElwGwAq8BUd80V4xJyrQUMDHlWi7xq+S9gq11IrQfcQcsRgmimMYrnMvwR74A== X-Received: by 2002:a5d:614d:0:b0:2bc:7e97:3d5f with SMTP id y13-20020a5d614d000000b002bc7e973d5fmr12182570wrt.0.1673618230146; Fri, 13 Jan 2023 05:57:10 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id n1-20020a5d67c1000000b002bc7f64efa3sm11683668wrw.29.2023.01.13.05.57.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 05:57:09 -0800 (PST) In-Reply-To: <83bkn2a733.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Jan 2023 15:37:36 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=rpluim@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302395 Archived-At: >>>>> On Fri, 13 Jan 2023 15:37:36 +0200, Eli Zaretskii said: Eli> Fixed. It's a clear case of a test that adapted the results to wh= at Eli> the code produced, not to the desired/expected value. It=CA=BCs fixed, but I=CA=BCll admit that I don=CA=BCt understand why: (should (equal "aa" (get-text-property (point) 'completion--string))) (next-completion 3) (should (equal "ac" (get-text-property (point) 'completion--string))) (previous-completion 2) (should (equal "aa" (get-text-property (point) 'completion--string))) So we go forward 3 from "aa" to get to "ac", but then to get back to "aa" it=CA=BCs back 2? Robert --=20