From: Robert Pluim <rpluim@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "Michael Albinus" <michael.albinus@gmx.de>,
emacs-devel@gnu.org, "Mattias Engdegård" <mattiase@acm.org>
Subject: Re: master 6ebce84ff2b: Use t for non-nil default values in boolean defcustom declarations
Date: Tue, 02 May 2023 10:03:16 +0200 [thread overview]
Message-ID: <87fs8fyxbv.fsf@gmail.com> (raw)
In-Reply-To: <87ttwz6if5.fsf@igel.home> (Andreas Schwab's message of "Sat, 29 Apr 2023 13:23:42 +0200")
>>>>> On Sat, 29 Apr 2023 13:23:42 +0200, Andreas Schwab <schwab@linux-m68k.org> said:
Andreas> On Apr 29 2023, Michael Albinus wrote:
>> Mattias Engdegård <mattiase@acm.org> writes:
>>
>> Hi Mattias,
>>
>>> Use t for non-nil default values in boolean defcustom declarations
>>>
>>> +(defcustom viper-ms-style-os-p
>>> + (not (not (memq system-type '(ms-dos windows-nt))))
>>
>> I'm just curious. Is there an advantage in using the (not (not ...))
>> pattern?
Andreas> Logically, (not (null ...)) would fit better.
Andreas> (not is just an alias of null, so both are the same, of course).
Yes, but (not (not ...)) maps nicely to '!!' in C
Iʼm very curious if this change will cause any issues :-)
Robert
--
next prev parent reply other threads:[~2023-05-02 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168268729579.28551.10245924430337302769@vcs2.savannah.gnu.org>
[not found] ` <20230428130816.81449C22A07@vcs2.savannah.gnu.org>
2023-04-29 7:39 ` master 6ebce84ff2b: Use t for non-nil default values in boolean defcustom declarations Michael Albinus
2023-04-29 9:03 ` Mattias Engdegård
2023-04-29 11:07 ` Michael Albinus
2023-04-29 11:23 ` Andreas Schwab
2023-05-02 8:03 ` Robert Pluim [this message]
2023-05-02 16:42 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs8fyxbv.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
--cc=michael.albinus@gmx.de \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.