From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 6ebce84ff2b: Use t for non-nil default values in boolean defcustom declarations Date: Tue, 02 May 2023 10:03:16 +0200 Message-ID: <87fs8fyxbv.fsf@gmail.com> References: <168268729579.28551.10245924430337302769@vcs2.savannah.gnu.org> <20230428130816.81449C22A07@vcs2.savannah.gnu.org> <87ildfxhlt.fsf@gmx.de> <87ttwz6if5.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28052"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Albinus , emacs-devel@gnu.org, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 02 10:04:34 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptkzw-00070H-Sc for ged-emacs-devel@m.gmane-mx.org; Tue, 02 May 2023 10:04:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptkyt-0006VE-Ee; Tue, 02 May 2023 04:03:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptkyr-0006TY-KT for emacs-devel@gnu.org; Tue, 02 May 2023 04:03:25 -0400 Original-Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptkyp-0008N7-Kj for emacs-devel@gnu.org; Tue, 02 May 2023 04:03:25 -0400 Original-Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-2f55ffdbaedso1986186f8f.2 for ; Tue, 02 May 2023 01:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683014597; x=1685606597; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=dWClBs+6OiZnJQp+hd1zXp3qGTVgDB/EjdwNFXdpi0Y=; b=Rc7s7n1mJRYAx6ExAij8NZ4QHPtC8zd82UaY9VQAoyCc6gLGCXFP/rYtn8XDuP2CcS k5BQx3c546b4x03U5DthE2s9VRr8vl14CYJ5mJ/2r+u9rtPb69TPcWdlhdNKO4aM1KN7 Lme0xg2JUIpIYiYaemedmfwnt0n4NxKmFT5PaMRr3cZwbSI9Pz/Tn4cqGDpwVZkuOuYg jhiRyyNTYcDDtzKBejyWehk/spAUNYmk4OjGjMKZoH+xTIU0+POk7MP9O/cvJVAAQ7C1 cNFRtdi0LxOmpAFICkfqIi0aRNbqZKSnhQZYyiIIs8SZE09lvAjQlmxoDyrNbqEme/Xw NI0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683014597; x=1685606597; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dWClBs+6OiZnJQp+hd1zXp3qGTVgDB/EjdwNFXdpi0Y=; b=AgcLoJmZBtX1SFLFivANsliltFOkFSv3emhZOxYfvq4/UvUQLH8PdTHfHtzBMLpZ1D B5vHGbe2Nol/nQGuMkW0C9tW+I/UuBSUIqPGB9G5eB1AO6QZ1YoTM37xgonnD3QhRQig +wGC5m5cA97oVyAtUyY7M4XsQm9fvjHEhZ/0F6u6gjCPUN2hcd37lVNM0c2hSh/hiw5L TTuXll9VMonyYTE0VCsmTzy4xjWfoD3ntZqd91sjiFyPGeQhZyS9Hjb5SwwPMuJz3sL5 tStZprGr/2M55UU15ZGpiv9gv/PkYh1H+r0yBER/IduwDHEDKNMH2WnjIpW7e7Uu+0H/ NT8Q== X-Gm-Message-State: AC+VfDy4Zach4u/ex/kvtKZvHpYjUqvBvqS8tsUonGzZPxXoWa3eyacv 4N/3KuIY0gupU3F0ESsd3/c= X-Google-Smtp-Source: ACHHUZ5kEUgXaqXktly9dd4GaKhfB1dMVL9YYjE2MYlzQNvwUUOM9W/JnCbrXI4f9cfSAkFeLXwkZg== X-Received: by 2002:adf:e74b:0:b0:306:3352:5ba3 with SMTP id c11-20020adfe74b000000b0030633525ba3mr2055070wrn.25.1683014597358; Tue, 02 May 2023 01:03:17 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id k6-20020a5d5186000000b003062b57ffd1sm5675229wrv.50.2023.05.02.01.03.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 01:03:16 -0700 (PDT) In-Reply-To: <87ttwz6if5.fsf@igel.home> (Andreas Schwab's message of "Sat, 29 Apr 2023 13:23:42 +0200") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305750 Archived-At: >>>>> On Sat, 29 Apr 2023 13:23:42 +0200, Andreas Schwab said: Andreas> On Apr 29 2023, Michael Albinus wrote: >> Mattias Engdeg=C3=83=C2=A5rd writes: >>=20 >> Hi Mattias, >>=20 >>> Use t for non-nil default values in boolean defcustom declarations >>>=20 >>> +(defcustom viper-ms-style-os-p >>> + (not (not (memq system-type '(ms-dos windows-nt)))) >>=20 >> I'm just curious. Is there an advantage in using the (not (not ...)) >> pattern? Andreas> Logically, (not (null ...)) would fit better. Andreas> (not is just an alias of null, so both are the same, of course= ). Yes, but (not (not ...)) maps nicely to '!!' in C I=CA=BCm very curious if this change will cause any issues :-) Robert --=20