all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Eglot tests on EMBA
Date: Fri, 31 Mar 2023 12:31:53 +0200	[thread overview]
Message-ID: <878rfddxeu.fsf@gmx.de> (raw)
In-Reply-To: <CALDnm530x9zdPnhe_JdXfW=c0LvRFE0x_ku3kHv3g55vaSJYXg@mail.gmail.com> ("João Távora"'s message of "Thu, 30 Mar 2023 13:45:51 +0100")

João Távora <joaotavora@gmail.com> writes:

Hi João,

> After reading the logs,  I think it comes down to how you installed
> pylsp on EMBA.   I think you should do it with
>
>    pip install "python-lsp-server[all]"
>
> which install its "providers", which are some type of contribs.

I'm not happy with this. EMBA installs a conservative list of software;
they shall be available as Debian bullseye package.

Since Debian bullseye does not offer the package python3-pylsp (which
will be available with a later Debian release), I install on EMBA
python3-pyls. This shall be sufficient, because (according to
eglot-server-programs) "pyls" is supported.

eglot-tests.el does not dertect this, it checks only for "pylsp". I
believe this shall be changed, the check shall be for all alternatives
configured in eglot-server-programs. And not only for python, but also
for other languages.

Because of this deficiency, I run "ln -s /usr/bin/pyls /usr/bin/pylsp"
on EMBA. But I dislike it.

> We could have code in eglot-tests.el to check if these "providers"
> are installed into pylsp, but I think it's better to just install
> pylsp like I provided, and start thinking of some other less
> problematic server for these tests.

Hmm, again, I don't believe we shall adapt everything just that the
tests run. It must be the other direction: eglot-tests must check the
environment, and do what's possible. You cannot always assume that
people are using bleeding edge software. It is a valid assumption, that
people use stable distributions, like Debian bullseye.

I have no idea what is needed internally, but Debian bullseye offers
also the packages

--8<---------------cut here---------------start------------->8---
Package python3-pyls-black
    bullseye (stable) (python): Black plugin for the Python Language Server
    0.4.6-3: all

Package python3-pyls-jsonrpc
    bullseye (stable) (python): Python server implementation of the JSON RPC 2.0 protocol
    0.4.0-2: all

Package python3-pyls-spyder
    bullseye (stable) (python): Spyder plugin for the Python Language Server
    0.3.0-3: all
--8<---------------cut here---------------end--------------->8---

Is there something we shall install?

> Maybe move the test to clangd.  I think it would be equally
> valid.  But I've not made up my mind if Eglot tests should test
> a wide or narrow field of language servers.  Opinions welcome.

Your decision.

> João

Best regards, Michael.



  reply	other threads:[~2023-03-31 10:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 12:09 Eglot tests on EMBA Michael Albinus
2023-03-29 14:34 ` Michael Albinus
2023-03-29 14:46   ` João Távora
2023-03-30 12:45     ` João Távora
2023-03-31 10:31       ` Michael Albinus [this message]
2023-03-31 10:50         ` João Távora
2023-03-31 12:14           ` Michael Albinus
2023-03-31 13:35             ` João Távora
2023-03-31 14:03               ` João Távora
2023-03-31 14:16                 ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rfddxeu.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.