From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Eglot tests on EMBA Date: Fri, 31 Mar 2023 12:31:53 +0200 Message-ID: <878rfddxeu.fsf@gmx.de> References: <87y1nyi5cq.fsf@gmx.de> <87tty3eide.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21119"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 31 12:32:45 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1piC3p-0005On-4b for ged-emacs-devel@m.gmane-mx.org; Fri, 31 Mar 2023 12:32:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piC3A-00052y-JW; Fri, 31 Mar 2023 06:32:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piC36-0004yX-14 for emacs-devel@gnu.org; Fri, 31 Mar 2023 06:32:01 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piC34-0002UE-5e for emacs-devel@gnu.org; Fri, 31 Mar 2023 06:31:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1680258714; i=michael.albinus@gmx.de; bh=qzjzkEKC32OdvK5nL7vhMA+T5GoNbKXejdlUl8RnP1s=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=k8WKet2QZu4h+l5cHlz07YaUEbi8gdFxtsZcsp0xEflbxImYaRsbv4XbMJ6ESZexE +lPj/RJ5AYNDTFIGIrZX/h0uBJZJQ9V79wb9KA8ruUys3698hN3LYfUqZKinSXJfrp Hggp0MrsmullcpCyUs/XQtzVktdmJwNCx9fxMp7vvEFiGzGKootbcryT6VWq9oQecq 1AUoYIPOTiUZ68rFz9Wvdzn4fb7SzXKkr0mC3yVCRQ+0uatejkVJOLt6msjzgDqvEP 4tPSkJbN0mwUcZLr4TYGCZmv48Nm8vczKj46AzrCc3B3gXUisop0Lvuvvtl38Oyjfx tYf8GavcRD/dA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.0]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M1po0-1pkOyA2DBw-002ErD; Fri, 31 Mar 2023 12:31:54 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Thu, 30 Mar 2023 13:45:51 +0100") X-Provags-ID: V03:K1:QnxfZAu+bgDFEUiR4nNsG+TsxQyQgVA6XWRLCrMY+/ZzQylFdEl C3QSx9MWLDKwQTMXqJQ6aRpveDp8ICnoYGeCZ2xLBgW0LhdkdGOeM72oSwx/cQSBS9nvB7P bpt9KeictfvnK2x49clHV+cDoJ4/bUEU8D1uWuKMaEHD7OWnWC+FimRytwD1NdSV2mkMsC1 rFy/QE84ccb5rjrVXsHpw== UI-OutboundReport: notjunk:1;M01:P0:rEkIHB7Lku0=;qqhGhWIbXj6jwAbXWBtf3AGqG06 FwCD2jVclffPp/icIph6wbaUhFlGh9YZoKRwwDSd+RS/HdbMw1vT2pxb95Tkwt9E3YtZ2sWuc EexUTtIDQ2V4MxsMEQOqLRBLw9vD+PN4X2YuwQraOxCicbILcQUb7yveXtZeSxHrjF0dgd0lq wTXY53rK2XTasR8o5qqGfhOcWpeyFIfCkyZ6MC0X34cWEckyg4TwHmuFfO8p7sn6mNZ8G45gL R7Mr/riFO98uhRJEpicEYq8x53MoNgnS09bMoTBtq8zmX2yZi0d7TiCFK5ITt2CGJvTaKqNXX P1/uytNriVlV4dfRn6gERFY0sC0V6zB5PufKQRLCSZK3CJxe2mdkkfuG0HISNuL7DLTlBpV95 fW2ruddNfWdy9n40BFo8pBZz0P2mNUR+IklEEnSr7Cc3jY8FNmAB6FXNrV+EIzHDF2aAg/iFO yrsjll4iMH1uM2XIyh7MTAvzgGIjwNEcqlvjedesEJr0Dn6853I5QU0ErwozHbVTqm/EgiZvc sot+UujFZetzSIzMiF1gsJvI65/DUFOX/tVP8j5KcID3g+zJp97FiO1J+U/z9AwQvcARRs5Vx ppNYSxUAHicXT3RsdnICVlKJjFyla6asFo/gS5xZAMrkXCRmnaUj9il5oOUltwu7qSxMfl8SU NNQ3ChDSatlLK/q/DG6j7FOUpeIrR30k1ufkNldKHz3Hq1oERyyYU86D7Jssrf3t26C/qaeuf 6oi/lXdcMHJCXVREnx3YJcfj/f4CLNvuHrk2pqx6ai7UFdegfBA0RwoyrgJCyQHXKZgsZNMC Received-SPF: pass client-ip=212.227.17.22; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304903 Archived-At: Jo=C3=A3o T=C3=A1vora writes: Hi Jo=C3=A3o, > After reading the logs, I think it comes down to how you installed > pylsp on EMBA. I think you should do it with > > pip install "python-lsp-server[all]" > > which install its "providers", which are some type of contribs. I'm not happy with this. EMBA installs a conservative list of software; they shall be available as Debian bullseye package. Since Debian bullseye does not offer the package python3-pylsp (which will be available with a later Debian release), I install on EMBA python3-pyls. This shall be sufficient, because (according to eglot-server-programs) "pyls" is supported. eglot-tests.el does not dertect this, it checks only for "pylsp". I believe this shall be changed, the check shall be for all alternatives configured in eglot-server-programs. And not only for python, but also for other languages. Because of this deficiency, I run "ln -s /usr/bin/pyls /usr/bin/pylsp" on EMBA. But I dislike it. > We could have code in eglot-tests.el to check if these "providers" > are installed into pylsp, but I think it's better to just install > pylsp like I provided, and start thinking of some other less > problematic server for these tests. Hmm, again, I don't believe we shall adapt everything just that the tests run. It must be the other direction: eglot-tests must check the environment, and do what's possible. You cannot always assume that people are using bleeding edge software. It is a valid assumption, that people use stable distributions, like Debian bullseye. I have no idea what is needed internally, but Debian bullseye offers also the packages --8<---------------cut here---------------start------------->8--- Package python3-pyls-black bullseye (stable) (python): Black plugin for the Python Language Server 0.4.6-3: all Package python3-pyls-jsonrpc bullseye (stable) (python): Python server implementation of the JSON RP= C 2.0 protocol 0.4.0-2: all Package python3-pyls-spyder bullseye (stable) (python): Spyder plugin for the Python Language Server 0.3.0-3: all --8<---------------cut here---------------end--------------->8--- Is there something we shall install? > Maybe move the test to clangd. I think it would be equally > valid. But I've not made up my mind if Eglot tests should test > a wide or narrow field of language servers. Opinions welcome. Your decision. > Jo=C3=A3o Best regards, Michael.