From: Michael Albinus <michael.albinus@gmx.de>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 58307@debbugs.gnu.org
Subject: bug#58307: 29.0.50; Fix battery mode over TRAMP on *BSD
Date: Wed, 05 Oct 2022 22:24:32 +0200 [thread overview]
Message-ID: <877d1ekohr.fsf@gmx.de> (raw)
In-Reply-To: <87ilkyfhlo.fsf@elite.giraud> (Manuel Giraud's message of "Wed, 05 Oct 2022 16:52:19 +0200")
Manuel Giraud <manuel@ledu-giraud.fr> writes:
> Hi,
Hi Manual,
> I'm using OpenBSD on a laptop. I'm also using battery-mode. Whenever,
> I'm accessing another machine over TRAMP, the string displayed by
> battery-mode become useless in this buffer.
>
> The attached patch fixes this issue. AFAIU, shell-command-to-string is
> using the current directory of the buffer and fails to find a usable
> "/usr/sbin/apm" on a remote Linux, for instance. So I'm using
> call-process that does call the local "/usr/sbin/apm".
The patch LGTM. There's one point: you have called your helper function
`call-process-to-string'. This looks like a general function, which
moght confuse users. Could you rename it to something like
`battery--call-process-to-string'? Also a comment might be helpful
explaining the problem.
> Best regards,
Best regards, Michael.
next prev parent reply other threads:[~2022-10-05 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 14:52 bug#58307: 29.0.50; Fix battery mode over TRAMP on *BSD Manuel Giraud
2022-10-05 20:24 ` Michael Albinus [this message]
2022-10-05 22:51 ` Stefan Kangas
2022-10-06 8:17 ` Manuel Giraud
2022-10-06 12:47 ` Lars Ingebrigtsen
2022-10-06 14:34 ` Manuel Giraud
2022-10-06 18:20 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d1ekohr.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=58307@debbugs.gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.