From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#58307: 29.0.50; Fix battery mode over TRAMP on *BSD Date: Wed, 05 Oct 2022 22:24:32 +0200 Message-ID: <877d1ekohr.fsf@gmx.de> References: <87ilkyfhlo.fsf@elite.giraud> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31244"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 58307@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 05 22:31:03 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogB2l-0007vm-6o for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Oct 2022 22:31:03 +0200 Original-Received: from localhost ([::1]:49454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogB2j-0008Cl-5P for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Oct 2022 16:31:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogAww-0005XI-I6 for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2022 16:25:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59099) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogAww-0000Kc-7F for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2022 16:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogAwv-0002q3-S5 for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2022 16:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Oct 2022 20:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58307 X-GNU-PR-Package: emacs Original-Received: via spool by 58307-submit@debbugs.gnu.org id=B58307.166500149210892 (code B ref 58307); Wed, 05 Oct 2022 20:25:01 +0000 Original-Received: (at 58307) by debbugs.gnu.org; 5 Oct 2022 20:24:52 +0000 Original-Received: from localhost ([127.0.0.1]:58177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogAwl-0002pc-M7 for submit@debbugs.gnu.org; Wed, 05 Oct 2022 16:24:51 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:53433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogAwf-0002pJ-QS for 58307@debbugs.gnu.org; Wed, 05 Oct 2022 16:24:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1665001476; bh=HDR9nSfX75wqGcDaqK/HvPaKM1G+yqLV9BI2QuL4kPs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=ccM/XMedCtsSHzAsDbciDw8SMN+C1vbCOKFYOTam13PrJNdYhrdm3tc/c5wYIiVI6 nR4BwMq9/tlrt515ORiPFGANW93alcuwxT3IAgkqQh2IGgHqzBgUAcQY6fNVxd1slI nX1gYotgBQN8rC6atl3H4UAmp7ZkD4RBcPCGPRm0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.148.171]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MG9g4-1oPegx2sUm-00GWD8; Wed, 05 Oct 2022 22:24:36 +0200 In-Reply-To: <87ilkyfhlo.fsf@elite.giraud> (Manuel Giraud's message of "Wed, 05 Oct 2022 16:52:19 +0200") X-Provags-ID: V03:K1:j3+Odujx+GbDphwrHeLjgPJhycP9C3xTmaWekk/nkequFfjffg7 LN6iR99xEyAtVTfmhEM/9xpdH0Wl7l70pNs6AaVEwyhZX+hxzhs01ZlkXLW/Emg4uQjbNnq zrBSTny5xD4I34ZMSsxbrjORcEQi8Wwlo09kgOiFuF5MHUqq4QVbhtK2TJJwLgY0WbYX9L9 9Ht3QwFFOLIkzXVPL2y3w== X-UI-Out-Filterresults: notjunk:1;V03:K0:EvKFga4T0O8=:Hzp/Rb3Sy2QRm0scBJc7I4 Q/ehd/dUqxHQvAp/eHi1eBihbPd3KMDiIOFKiJfRIWdZFU9ffWeVXABJxO0ekPa598/RvuKLi xOiHvO6WGRl2OGoN2/yVy9QDVO4mzlklQRIDGeoKmFYjUHT0s3u4g7MZPxk5GBZZEr1yd9Xb3 VEwctQ+pkSg943EY49Y0OZGYWoR9qIuhMi3IQMMk19FNX/RrZ22FGUo7CwwRKoLPzBmjjJYvU 8t7R4CbwqUZxdQ868mDKW9va4ojxj6iyhWP/9sdSGku2v2kuZNzYLTvemZDjnMYb37BGqf2Xz clQVOZOrgZINpvs3CyU4MDe3yk0DYYXwsEfGcsvNiMoTceeKqwMbXAGSA8Cv3cUvBS6cIMss9 tcHf7UHEWnd5hMEuHGHSmPPIJxhkXndlcOg0V+qsocRFX5bOe9egi97vXezBBihfeLyWcZgz1 ArkmaO5xYVIsVgaZOut0SI4dfAwf5l4cZLkvLGNN5jkcJQGMBelPkBzKuWfiZQr7EfRy4cP5j ZZKRvFczr2PXMls1MSjfC9ALVJRiXygiurM2wWYvi5UAp5a+g5kr4FldpJvUXmOEZDk1ETQk7 E8VLW5NWpPVxjBVJjuPexcTkprv++Eb/m/Xcq8tmA2E0HcZVKpsCx0015ETv3qiZmBa7tcQ+s lA/GecRVI4oLZRBhTkFaTQmivvJlfECmxAIo5yFloVdvoF8fNtyO80rj4iP3rKjX/o5m8YNtM 5y8bD+T7ah2/xltEnNQsOE2LDw0+ENkvp9zHNmu0TZMu9x4TlMVl5hnGOYH/KW0iMTXI6rur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244574 Archived-At: Manuel Giraud writes: > Hi, Hi Manual, > I'm using OpenBSD on a laptop. I'm also using battery-mode. Whenever, > I'm accessing another machine over TRAMP, the string displayed by > battery-mode become useless in this buffer. > > The attached patch fixes this issue. AFAIU, shell-command-to-string is > using the current directory of the buffer and fails to find a usable > "/usr/sbin/apm" on a remote Linux, for instance. So I'm using > call-process that does call the local "/usr/sbin/apm". The patch LGTM. There's one point: you have called your helper function `call-process-to-string'. This looks like a general function, which moght confuse users. Could you rename it to something like `battery--call-process-to-string'? Also a comment might be helpful explaining the problem. > Best regards, Best regards, Michael.