From: Lars Ingebrigtsen <larsi@gnus.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Jean Louis <bugs@gnu.support>, 33007@debbugs.gnu.org
Subject: bug#33007: 27.0.50; Proposal for function to edit and return string
Date: Mon, 25 Apr 2022 09:50:41 +0200 [thread overview]
Message-ID: <875ymx7ga6.fsf@gnus.org> (raw)
In-Reply-To: <871qxlj293.fsf@web.de> (Michael Heerdegen's message of "Mon, 25 Apr 2022 05:00:40 +0200")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> One thing I found: at the end of `string-edit', you have
>
> #+begin_src emacs-lisp
> (message "%S" (substitute-command-keys
> "Type `C-c C-c' when you've finished editing"))
> #+end_src
>
> That should be "%s" - we don't want a quoted, `read'able string
> messaged.
Yup; fixed now (and I made it use the \[...] thing at the same time).
> Second: I find the name of `read-string-from-buffer' a bit misleading -
> what about `edit-string-in-buffer'? The emphasis should be on "edit",
> because a string is already present, the function doesn't just prompt
> for a (new) string.
Yes, I was waffling between various names while I was typing the file,
and renamed the function to read-string-from-buffer while writing the
documentation. :-) I thought it might make sense from a discovery
point of view to have something that people who looked for `read-string'
would find easily (and could plug into existing functions easily).
But this function will probably mostly be used for editing strings, as
you point out, so `edit-string-in-buffer' sounds like a good idea to me.
Anybody have any further opinions before I rename?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-04-25 7:50 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 20:49 bug#33007: 27.0.50; Proposal for function to edit and return string Jean Louis
2018-10-11 2:36 ` Eli Zaretskii
2018-10-11 6:33 ` Jean Louis
2018-10-11 13:31 ` Michael Heerdegen
2018-10-11 13:40 ` Jean Louis
2018-10-11 14:24 ` Eli Zaretskii
2018-10-11 20:20 ` Michael Heerdegen
2018-10-11 21:23 ` Drew Adams
2018-10-12 4:26 ` Eli Zaretskii
2018-10-12 11:26 ` Michael Heerdegen
2018-10-12 12:41 ` Eli Zaretskii
2022-04-24 13:15 ` Lars Ingebrigtsen
2022-04-25 3:00 ` Michael Heerdegen
2022-04-25 7:50 ` Lars Ingebrigtsen [this message]
2022-04-25 15:42 ` Juri Linkov
2022-04-25 22:26 ` Michael Heerdegen
2022-04-26 7:23 ` Juri Linkov
2022-04-26 9:56 ` Lars Ingebrigtsen
2022-04-26 15:36 ` Juri Linkov
2022-04-27 12:09 ` Lars Ingebrigtsen
2022-04-26 9:55 ` Lars Ingebrigtsen
2022-04-26 15:39 ` Juri Linkov
2022-04-27 12:10 ` Lars Ingebrigtsen
2022-04-27 16:44 ` Juri Linkov
2022-04-27 17:05 ` Lars Ingebrigtsen
2022-04-28 7:32 ` Juri Linkov
2022-04-28 10:19 ` Lars Ingebrigtsen
2022-05-08 18:22 ` Juri Linkov
2022-05-09 9:49 ` Lars Ingebrigtsen
2022-05-09 18:52 ` Juri Linkov
2022-05-10 1:53 ` Lars Ingebrigtsen
2022-04-25 22:46 ` Michael Heerdegen
2022-04-26 9:58 ` Lars Ingebrigtsen
2018-10-11 13:55 ` Eli Zaretskii
2018-10-11 14:01 ` Michael Heerdegen
2018-10-11 14:08 ` Jean Louis
2018-10-11 14:16 ` Michael Heerdegen
2018-10-11 14:27 ` Eli Zaretskii
2018-10-11 14:36 ` Jean Louis
[not found] ` <<87lg74zk2k.fsf@web.de>
[not found] ` <<834ldsy31m.fsf@gnu.org>
2018-10-11 14:41 ` Drew Adams
2018-10-11 16:40 ` Eric Abrahamsen
2018-10-15 20:34 ` Juri Linkov
2018-10-15 22:07 ` Drew Adams
2018-10-16 22:12 ` Juri Linkov
2018-10-16 23:05 ` Drew Adams
2018-10-17 15:39 ` Michael Heerdegen
[not found] <<86pnwh4je8.fsf@protected.rcdrun.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ymx7ga6.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=33007@debbugs.gnu.org \
--cc=bugs@gnu.support \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.