From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#33007: 27.0.50; Proposal for function to edit and return string Date: Mon, 25 Apr 2022 09:50:41 +0200 Message-ID: <875ymx7ga6.fsf@gnus.org> References: <86pnwh4je8.fsf@protected.rcdrun.com> <83bm81xl84.fsf@gnu.org> <20181011063321.GD27672@protected.rcdrun.com> <87lg74zk2k.fsf@web.de> <87v8uybp1c.fsf@gnus.org> <871qxlj293.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11624"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Jean Louis , 33007@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 25 09:54:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nitY1-0002o4-De for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Apr 2022 09:54:17 +0200 Original-Received: from localhost ([::1]:52192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nitY0-0008Sr-4l for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Apr 2022 03:54:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nitUt-0005ek-Co for bug-gnu-emacs@gnu.org; Mon, 25 Apr 2022 03:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39169) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nitUs-0005eE-Cl for bug-gnu-emacs@gnu.org; Mon, 25 Apr 2022 03:51:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nitUs-0001pJ-Bl for bug-gnu-emacs@gnu.org; Mon, 25 Apr 2022 03:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Apr 2022 07:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33007 X-GNU-PR-Package: emacs Original-Received: via spool by 33007-submit@debbugs.gnu.org id=B33007.16508730567006 (code B ref 33007); Mon, 25 Apr 2022 07:51:02 +0000 Original-Received: (at 33007) by debbugs.gnu.org; 25 Apr 2022 07:50:56 +0000 Original-Received: from localhost ([127.0.0.1]:33066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nitUl-0001ow-Rg for submit@debbugs.gnu.org; Mon, 25 Apr 2022 03:50:56 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nitUk-0001oj-9A for 33007@debbugs.gnu.org; Mon, 25 Apr 2022 03:50:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=haqvw33GRTKEomRJfhPDQVSlQ0TqrnlgTzsP2/y/8mE=; b=R3A+d/Fvz+PAwst4jlG7XLksnl p/radHf0sIUx542KBRzWQQJmwHf2bHrEgs9dvKN1VB//RWEVAdY1aaZLtb7gHykNvdrhmb452cLBv IXc2IGvZ0uCkDDoWFLCp2kIfrc8ATxLAbu9nEpvwHNIXpP5/j8wVSKuAhBZ2Ut2WBGjM=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nitUa-0007xr-PK; Mon, 25 Apr 2022 09:50:46 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUEAgMnEyVLGQ5k LRwtDQqGOCK0bkSfWTPFdknclF9qNziPVkr7voUpKSr///8QDAzYAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+YEGQcZGrd1qg0AAAFxSURBVDjL7dHNTsJAEAfwAZZ7eyXZBNcSr0hrN9FLLUtIvAJGrxLK hzeaFDiTtPACwCSe9AlMVF7CAzxA38WVmLC2HAxn57LJ/LL/mewCHK4M/MPfIXMsZMvEOQj5BxDi 0NVauyjcYrovzqYmbzVTfVIN/GAW+fsx5OfM9RdjnAo3BU4dw6gMbirKAbtjASk5CRA3Ihca1htP 7lW/+jCx8/jeTUGbe4j+/dJKQB7n4RMiLo0EZCc4kn1sp7a6w0D2V37iiTXC55NPxEUKCrVeJbRx kXisDBSqY7+E2LGSAIQHfVw0TgC2oKsALp91X6xrDeJt/BvYRcsS5xpQKRslivBeZLlDDfSY0lgB hzAmagMZRamuRAnhXq4NeyCHxzFVfst0hWm5PQkySlc25swgpOS9yhtbnW72YFeYwWzvWQJV9gW4 HTLG7O4p7NZVYclMFnRNCXKIGuX5Db6Kmt9A43ijgLcOvFF5FwWHS9PguPoC7oVs+F7ddOsAAAAl dEVYdGRhdGU6Y3JlYXRlADIwMjItMDQtMjVUMDc6MjU6MjYrMDA6MDCHAqnbAAAAJXRFWHRkYXRl Om1vZGlmeQAyMDIyLTA0LTI1VDA3OjI1OjI2KzAwOjAw9l8RZwAAAABJRU5ErkJggg== X-Now-Playing: Prince's _Sign 'O' the Times (4): Vault Tracks I_: "Strange Relationship" In-Reply-To: <871qxlj293.fsf@web.de> (Michael Heerdegen's message of "Mon, 25 Apr 2022 05:00:40 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230614 Archived-At: Michael Heerdegen writes: > One thing I found: at the end of `string-edit', you have > > #+begin_src emacs-lisp > (message "%S" (substitute-command-keys > "Type `C-c C-c' when you've finished editing")) > #+end_src > > That should be "%s" - we don't want a quoted, `read'able string > messaged. Yup; fixed now (and I made it use the \[...] thing at the same time). > Second: I find the name of `read-string-from-buffer' a bit misleading - > what about `edit-string-in-buffer'? The emphasis should be on "edit", > because a string is already present, the function doesn't just prompt > for a (new) string. Yes, I was waffling between various names while I was typing the file, and renamed the function to read-string-from-buffer while writing the documentation. :-) I thought it might make sense from a discovery point of view to have something that people who looked for `read-string' would find easily (and could plug into existing functions easily). But this function will probably mostly be used for editing strings, as you point out, so `edit-string-in-buffer' sounds like a good idea to me. Anybody have any further opinions before I rename? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no