bug#61832: 30.0.50; Missing auth-source option for ldap

bug#61832: 30.0.50; Missing auth-source option for ldap

[Fabrice Bauzac-Stehly]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

Hello,

The variable ldap-host-parameters-alist accepts to enable Auth-Source by
adding "auth-source t" in the list for a host.

However, I have noticed that its defcustom is missing the corresponding
option.

May I propose the attached change to add the missing item?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-missing-auth-source-option-for-ldap.patch --]
[-- Type: text/x-patch, Size: 1095 bytes --]

From 3ba253967a9db196f00b494f0e1d39ced8d7a0f7 Mon Sep 17 00:00:00 2001
From: Fabrice Bauzac <fbauzac@amadeus.com>
Date: Mon, 15 Aug 2022 11:46:19 +0200
Subject: [PATCH] Add missing auth-source option for ldap

* lisp/net/ldap.el (ldap-host-parameters-alist):
Add a missing item for auth-source in the defcustom.

Copyright-paperwork-exempt: yes
---
 lisp/net/ldap.el | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lisp/net/ldap.el b/lisp/net/ldap.el
index 78405414a28..bc98e024396 100644
--- a/lisp/net/ldap.el
+++ b/lisp/net/ldap.el
@@ -150,7 +150,12 @@ ldap-host-parameters-alist
 				   :tag "Size Limit"
 				   :inline t
 				   (const :tag "Size Limit" sizelimit)
-				   (integer :tag "(number of records)"))))))
+				   (integer :tag "(number of records)"))
+                                  (list
+				   :tag "Auth-Source"
+				   :inline t
+                                   (const auth-source)
+				   (boolean :tag "Use Auth-Source"))))))
 
 (defcustom ldap-ldapsearch-prog "ldapsearch"
   "The name of the ldapsearch command line program."
-- 
2.25.1


[-- Attachment #3: Type: text/plain, Size: 95 bytes --]


Thanks!

Best regards

-- 
Fabrice Bauzac-Stehly
PGP 01EEACF8244E9C14B551C5256ADA5F189BD322B6

bug#61832: 30.0.50; Missing auth-source option for ldap

[Robert Pluim]

>>>>> On Sun, 26 Feb 2023 21:38:35 +0100, Fabrice Bauzac-Stehly <libnoon@orange.fr> said:

    Fabrice> Hello,
    Fabrice> The variable ldap-host-parameters-alist accepts to enable Auth-Source by
    Fabrice> adding "auth-source t" in the list for a host.

    Fabrice> However, I have noticed that its defcustom is missing the corresponding
    Fabrice> option.

Hi, this was corrected back in September (by a patch sent by you :-) ).
The change is in emacs-29 and master.

Robert
-- 

bug#61832: 30.0.50; Missing auth-source option for ldap

[Fabrice Bauzac-Stehly]

Robert Pluim <rpluim@gmail.com> writes:
> The change is in emacs-29 and master.
Oops, sorry!  Closing this bug then.