From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 48281@debbugs.gnu.org, Spencer Baugh <sbaugh@catern.com>,
Eli Zaretskii <eliz@gnu.org>
Subject: bug#48281: buffer_local_value and find_symbol_value duplicate functionality
Date: Sat, 02 Jul 2022 15:22:59 +0200 [thread overview]
Message-ID: <8735fj1wek.fsf@gnus.org> (raw)
In-Reply-To: <jwvzgx55pl7.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 08 May 2021 09:26:31 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> So any effort to unify the two should focus on not slowing down
> `find_symbol_value`. The fact that here are two functions is acceptable
> to me, but indeed the two code paths are uncomfortably different, so I'd
> welcome changes (including minor changes) to make them more similar, tho
> maybe the best we can do is add comments explaining why the two code
> paths give the same result.
I think the conclusion here is that it's not worth the added complexity
to merge these two functions, so I've now added a comment about this
instead.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2022-07-02 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 22:44 bug#48281: buffer_local_value and find_symbol_value duplicate functionality Spencer Baugh
2021-05-08 7:10 ` Eli Zaretskii
2021-05-08 13:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-02 13:22 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735fj1wek.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=48281@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=sbaugh@catern.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.