From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#48281: buffer_local_value and find_symbol_value duplicate functionality Date: Sat, 02 Jul 2022 15:22:59 +0200 Message-ID: <8735fj1wek.fsf@gnus.org> References: <87im3up3ji.fsf@catern.com> <83r1ihaeg6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31573"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 48281@debbugs.gnu.org, Spencer Baugh , Eli Zaretskii To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 02 15:24:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7d6Z-000822-QI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Jul 2022 15:24:11 +0200 Original-Received: from localhost ([::1]:59186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7d6Y-00072W-FI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Jul 2022 09:24:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7d6R-00071A-FP for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 09:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46298) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o7d6Q-00065K-Cr for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 09:24:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o7d6Q-0006k5-5q for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 09:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jul 2022 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48281 X-GNU-PR-Package: emacs Original-Received: via spool by 48281-submit@debbugs.gnu.org id=B48281.165676819625853 (code B ref 48281); Sat, 02 Jul 2022 13:24:02 +0000 Original-Received: (at 48281) by debbugs.gnu.org; 2 Jul 2022 13:23:16 +0000 Original-Received: from localhost ([127.0.0.1]:40193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7d5g-0006iu-IP for submit@debbugs.gnu.org; Sat, 02 Jul 2022 09:23:16 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:38866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7d5b-0006iU-Ns for 48281@debbugs.gnu.org; Sat, 02 Jul 2022 09:23:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=maA/CpXM6Fr3J2muk8BixIwqldD7/S3Lkpj+uL1y52w=; b=FstPC+qTAgXkq3K4ARLk0EJMoQ m7jxyvtyWm+NK65G6wGi2VvIzyZBo1fN5sCg4NidM7GLf3lyA3hqUFgE6GgyfaGMDkG0GB7vVdhUz w0WXEcWNLKZcM+0UmuFugTT8NM5VWSg9dXyhGpjgjo8uqUauNo+nlTyg1ttngkXdETXc=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7d5Q-0002a4-0o; Sat, 02 Jul 2022 15:23:02 +0200 In-Reply-To: (Stefan Monnier's message of "Sat, 08 May 2021 09:26:31 -0400") X-Now-Playing: The Clash's _Sandinista!_: "The Call Up" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235914 Archived-At: Stefan Monnier writes: > So any effort to unify the two should focus on not slowing down > `find_symbol_value`. The fact that here are two functions is acceptable > to me, but indeed the two code paths are uncomfortably different, so I'd > welcome changes (including minor changes) to make them more similar, tho > maybe the best we can do is add comments explaining why the two code > paths give the same result. I think the conclusion here is that it's not worth the added complexity to merge these two functions, so I've now added a comment about this instead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no