From: Karl Fogel <kfogel@red-bean.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Gabriel <gabriel376@hotmail.com>, 59581@debbugs.gnu.org
Subject: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks
Date: Mon, 18 Dec 2023 17:51:39 -0600 [thread overview]
Message-ID: <8734vzm5mc.fsf@red-bean.com> (raw)
In-Reply-To: <83a647ikbs.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 01 Dec 2022 10:45:11 +0200")
On 01 Dec 2022, Eli Zaretskii wrote:
>> From: Gabriel <gabriel376@hotmail.com>
>> Date: Fri, 25 Nov 2022 16:19:38 -0300
>>
>> Description:
>>
>> Add completions details (see `completions-detailed') to
>> Bookmarks. It
>> affects all bookmark functions that make uses of
>> `bookmark-completing-read' (e.g.: `bookmark-jump',
>> `bookmark-relocate',
>> `bookmark-insert-location', `bookmark-rename' etc). See also
>> [1].
>>
>> [1]
>> https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html
>
>Karl, any comments to the patch?
I applied this patch, reloaded bookmark.el, and then tested `M-x
bookmark-jump' in two ways:
1) With `completions-detailed' == nil (my default)
2) With `completions-detailed' == t
In case (1) I saw the expected default behavior. My bookmarks
completed normally by name, and just their names were offered
during completion.
In case (2), though, things seemed broken. The "*Completions*"
buffer says "19 possible completions:" at the top (as expected),
but the buffer is otherwise blank. And when I hit SPC or TAB at
the "Jump to bookmark:" prompt, I get "[Wrong type argument:
stringp, nil]" in the minibuffer. My "*Messages*" buffer fills
with messages like this:
Making completion list...
#<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_56>: \
Wrong type argument: stringp, nil
Similar behavior happens for all the functions that depend on
`bookmark-completing-read'.
This is in Emacs 30.0.50 (built today from 'master', commit
1d5d2f16c330e).
Gabriel, does the patch maybe need a bit of updating? I assume it
worked for in the version of Emacs you originally wrote it in
(which would be from a littl over a year ago now -- sorry for the
delay; I wish I'd been able to follow up to this sooner).
Best regards,
-Karl
prev parent reply other threads:[~2023-12-18 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 19:19 bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks Gabriel
2022-12-01 8:45 ` Eli Zaretskii
2023-12-18 23:51 ` Karl Fogel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734vzm5mc.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=59581@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gabriel376@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.