From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.bugs Subject: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks Date: Mon, 18 Dec 2023 17:51:39 -0600 Message-ID: <8734vzm5mc.fsf@red-bean.com> References: <83a647ikbs.fsf@gnu.org> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12924"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gabriel , 59581@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 19 00:52:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFNPM-0003An-4P for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Dec 2023 00:52:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFNP0-0007Fg-0X; Mon, 18 Dec 2023 18:52:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFNOy-0007FC-JE for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 18:52:00 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rFNOy-0005d9-AF for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 18:52:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rFNOz-0000Lh-Rc for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 18:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Karl Fogel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Dec 2023 23:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59581-submit@debbugs.gnu.org id=B59581.17029435071298 (code B ref 59581); Mon, 18 Dec 2023 23:52:01 +0000 Original-Received: (at 59581) by debbugs.gnu.org; 18 Dec 2023 23:51:47 +0000 Original-Received: from localhost ([127.0.0.1]:33802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFNOk-0000Ks-LK for submit@debbugs.gnu.org; Mon, 18 Dec 2023 18:51:47 -0500 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:41432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFNOh-0000Ka-2w for 59581@debbugs.gnu.org; Mon, 18 Dec 2023 18:51:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date: Reply-To:References:In-Reply-To:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oCdkENhOaiHYsUTLgdWOAqqJeT7kkGg/ft2FEhrDRKg=; t=1702943500; x=1704153100; b=R3Apmk7/369K0mVnCQH+tF0hIs37jgUirRaCPd+Jd1bE6r2viRw7jLZJeDcZfSyzGOQyOuk3LVD BpIMB35vB8Q0X5McniImIQ9f2Kg2YwbTyMrgnGVvzrUeobLbvCFlS+gH1ea488Iw9M5D8XXNYvtMy EDlYHgEeezuas5jEvsUHNcd/miFnn9TRkbDLM6MyYkV74rROVQsrO7PniSYiI1GqeYb449J0MycPK UczlZFZ6NDLKqW1QT63TAuAs70CDaQCH+0HD/S5WrcBP1rrMqosFeKSSiFylIqSnEVm0OXPiatTNX EcLHxHf7L+yQ7S8jiJ4/vAI8IGkRBUeLVp1A==; Original-Received: from [12.106.183.66] (port=55605 helo=hummy) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFNOd-007jVw-PN; Mon, 18 Dec 2023 23:51:39 +0000 In-Reply-To: <83a647ikbs.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 01 Dec 2022 10:45:11 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276490 Archived-At: On 01 Dec 2022, Eli Zaretskii wrote: >> From: Gabriel >> Date: Fri, 25 Nov 2022 16:19:38 -0300 >> >> Description: >> >> Add completions details (see `completions-detailed') to >> Bookmarks. It >> affects all bookmark functions that make uses of >> `bookmark-completing-read' (e.g.: `bookmark-jump', >> `bookmark-relocate', >> `bookmark-insert-location', `bookmark-rename' etc). See also >> [1]. >> >> [1] >> https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html > >Karl, any comments to the patch? I applied this patch, reloaded bookmark.el, and then tested `M-x bookmark-jump' in two ways: 1) With `completions-detailed' == nil (my default) 2) With `completions-detailed' == t In case (1) I saw the expected default behavior. My bookmarks completed normally by name, and just their names were offered during completion. In case (2), though, things seemed broken. The "*Completions*" buffer says "19 possible completions:" at the top (as expected), but the buffer is otherwise blank. And when I hit SPC or TAB at the "Jump to bookmark:" prompt, I get "[Wrong type argument: stringp, nil]" in the minibuffer. My "*Messages*" buffer fills with messages like this: Making completion list... #: \ Wrong type argument: stringp, nil Similar behavior happens for all the functions that depend on `bookmark-completing-read'. This is in Emacs 30.0.50 (built today from 'master', commit 1d5d2f16c330e). Gabriel, does the patch maybe need a bit of updating? I assume it worked for in the version of Emacs you originally wrote it in (which would be from a littl over a year ago now -- sorry for the delay; I wish I'd been able to follow up to this sooner). Best regards, -Karl