Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Jose A Ortega Ruiz <jao@gnu.org>]

On Wed, Sep 07 2022, Jose A Ortega Ruiz wrote:

> On Wed, Sep 07 2022, Stefan Monnier wrote:
>
>> Sam Steingold [2022-09-06 15:47:23] wrote:
>>> Error in winner-save-old-configurations (flyspell-post-command-hook):
>>> (wrong-type-argument stringp nil)
>>
>> Hmm... actually, this is a good clue: in this error message the part
>> after "in" should be the hook's name.
>>
>> So I suspect the problem comes from my
>> commit 5cae71834bd55e0bf90689b12b801206ee8c9da9.
>>
>> More specifically, I suspect that the (hideous) patch below might fix
>> your problem.  Could you confirm (so I can find a better fix)?
>>
>>
>>         Stefan
>>
>>
>> diff --git a/src/keyboard.c b/src/keyboard.c
>> index 77280d08c5b..6b4253b7256 100644
>> --- a/src/keyboard.c
>> +++ b/src/keyboard.c
>> @@ -1887,6 +1887,7 @@ safe_run_hook_funcall (ptrdiff_t nargs, Lisp_Object *args)
>>    args[0] = hook, args[1] = fun;
>>    internal_condition_case_n (safe_run_hooks_1, nargs, args,
>>                               Qt, safe_run_hooks_error);
>> +  args[0] = fun, args[1] = hook;
>>    return Qnil;
>>  }
>
> this also seems to be solving the problem for me, thanks!

sorry, i spoke too quickly.  i still see the problem with this patch
applied.  it often happens when i press C-SPC, which eventually switchs
to a different frame in a terminal window, and then, upon landing there,
i see messages like

  Error in winner-save-old-configurations (transient--post-command-hook): (wrong-type-argument stringp [3 67108896]) [3 times]

i can get the 3 times thing by keeping pressing C-SPC (which in my
binding just stays in the same frame and does nothing).  turning on
debug on error has no effect, and transient--post-command-hook happens
too often to put a break there.

hope this helps a bit,
jao
-- 
Inglish iz issenshali a langwidje dhat, wen rittun fonetkli, iz
ilejibul tu netiv spikerz.
 -Peter Bleackley