From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jose A Ortega Ruiz Newsgroups: gmane.emacs.devel Subject: Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times] Date: Wed, 07 Sep 2022 23:57:45 +0100 Message-ID: <871qsmztau.fsf@mail.jao.io> References: <87czc7ynq6.fsf@mail.jao.io> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32940"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 08 00:58:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oW40Q-0008PH-8u for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Sep 2022 00:58:50 +0200 Original-Received: from localhost ([::1]:34988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oW40O-0001bN-Ry for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 18:58:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oW3zT-0000uX-KH for emacs-devel@gnu.org; Wed, 07 Sep 2022 18:57:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oW3zS-0001ft-Ct; Wed, 07 Sep 2022 18:57:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=fEvZyMoDH+OILzRSK9ETiK7jgCP3LhOzBxJF5wCpUC8=; b=pSRUoFpljTc5eCa5uZ4C GxnKEB1Vrlz5vKXX402SVLsZ7EsPwwMsbICRf8LgV9N1TbDmrmkba9abn39W+cDBMHVsBDplAUtTX PbzSBJyyBI8OLtwFbbm9AjqwdZmTrU/o7lO5YMQr8HP0chXn8SD87xF3L2LT6Qmn6BDiVEJ33dn35 8u9StxKXKMs3jLWh5zJN8/gZq0zd7IYOAh1/HIrCNc5uGS8NP3tvGPCh//4b+a1RQtAyQ+oX1fqxy Rs5gx2j0WUPdodXShbE55xgh129qdM2R4+Ibc/tr8TJXlSnX8qe8k9tIu2+4AeTJKcHnjtlQm2SWi 93sf98lHVhaXUg==; Original-Received: from cpc103048-sgyl39-2-0-cust502.18-2.cable.virginm.net ([92.233.85.247]:46228 helo=rivendell.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oW3zR-0008J5-Tp; Wed, 07 Sep 2022 18:57:50 -0400 Original-Received: from localhost (rivendell.localdomain [local]) by rivendell.localdomain (OpenSMTPD) with ESMTPA id e1206e9b; Wed, 7 Sep 2022 22:57:45 +0000 (UTC) In-Reply-To: <87czc7ynq6.fsf@mail.jao.io> X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294886 Archived-At: On Wed, Sep 07 2022, Jose A Ortega Ruiz wrote: > On Wed, Sep 07 2022, Stefan Monnier wrote: > >> Sam Steingold [2022-09-06 15:47:23] wrote: >>> Error in winner-save-old-configurations (flyspell-post-command-hook): >>> (wrong-type-argument stringp nil) >> >> Hmm... actually, this is a good clue: in this error message the part >> after "in" should be the hook's name. >> >> So I suspect the problem comes from my >> commit 5cae71834bd55e0bf90689b12b801206ee8c9da9. >> >> More specifically, I suspect that the (hideous) patch below might fix >> your problem. Could you confirm (so I can find a better fix)? >> >> >> Stefan >> >> >> diff --git a/src/keyboard.c b/src/keyboard.c >> index 77280d08c5b..6b4253b7256 100644 >> --- a/src/keyboard.c >> +++ b/src/keyboard.c >> @@ -1887,6 +1887,7 @@ safe_run_hook_funcall (ptrdiff_t nargs, Lisp_Object *args) >> args[0] = hook, args[1] = fun; >> internal_condition_case_n (safe_run_hooks_1, nargs, args, >> Qt, safe_run_hooks_error); >> + args[0] = fun, args[1] = hook; >> return Qnil; >> } > > this also seems to be solving the problem for me, thanks! sorry, i spoke too quickly. i still see the problem with this patch applied. it often happens when i press C-SPC, which eventually switchs to a different frame in a terminal window, and then, upon landing there, i see messages like Error in winner-save-old-configurations (transient--post-command-hook): (wrong-type-argument stringp [3 67108896]) [3 times] i can get the 3 times thing by keeping pressing C-SPC (which in my binding just stays in the same frame and does nothing). turning on debug on error has no effect, and transient--post-command-hook happens too often to put a break there. hope this helps a bit, jao -- Inglish iz issenshali a langwidje dhat, wen rittun fonetkli, iz ilejibul tu netiv spikerz. -Peter Bleackley