From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 69983@debbugs.gnu.org
Subject: bug#69983: Use category for display-buffer-alist
Date: Thu, 04 Apr 2024 09:16:17 +0300 [thread overview]
Message-ID: <86wmpdu0fa.fsf@mail.linkov.net> (raw)
In-Reply-To: <3e7b8e64-0a5f-4888-a443-9c69a5fffd98@gmx.at> (martin rudalics's message of "Mon, 25 Mar 2024 10:41:33 +0100")
>> 'display-comint-buffer-action' and 'display-tex-shell-buffer-action'
>> are out of place in window.el, and they are redundant per se.
>>
>> What these variables are trying to achieve is already possible
>> to do by using a 'category' in 'display-buffer-alist'.
>>
>> Or we need to keep backward-compatibility? Then the first step
>> to deprecate there variables would be something like this:
>
> Please proceed as carefully as possible, here might be dragons.
Ok, here is a complete patch:
diff --git a/lisp/window.el b/lisp/window.el
index 3867f6fa6ef..29e7310958b 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -8923,7 +8923,8 @@ pop-to-buffer-same-window
another window."
(pop-to-buffer buffer display-buffer--same-window-action norecord))
-(defcustom display-comint-buffer-action display-buffer--same-window-action
+(defcustom display-comint-buffer-action
+ (append display-buffer--same-window-action '((category . comint)))
"`display-buffer' action for displaying comint buffers."
:type display-buffer--action-custom-type
:risky t
@@ -8931,8 +8932,14 @@ display-comint-buffer-action
:group 'windows
:group 'comint)
+(make-obsolete-variable
+ 'display-comint-buffer-action
+ "use a `(category . comint)' condition in `display-buffer-alist'."
+ "30.1")
+
(defcustom display-tex-shell-buffer-action '(display-buffer-in-previous-window
- (inhibit-same-window . t))
+ (inhibit-same-window . t)
+ (category . tex-shell))
"`display-buffer' action for displaying TeX shell buffers."
:type display-buffer--action-custom-type
:risky t
@@ -8940,6 +8947,11 @@ display-tex-shell-buffer-action
:group 'windows
:group 'tex-run)
+(make-obsolete-variable
+ 'display-tex-shell-buffer-action
+ "use a `(category . tex-shell)' condition in `display-buffer-alist'."
+ "30.1")
+
(defun read-buffer-to-switch (prompt)
"Read the name of a buffer to switch to, prompting with PROMPT.
Return the name of the buffer as a string.
next prev parent reply other threads:[~2024-04-04 6:16 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 17:19 bug#69983: Use category for display-buffer-alist Juri Linkov
2024-03-25 9:41 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-25 17:12 ` Juri Linkov
2024-03-26 9:55 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-27 7:15 ` Juri Linkov
2024-03-28 7:47 ` Juri Linkov
2024-03-28 8:23 ` Eli Zaretskii
2024-03-28 17:46 ` Juri Linkov
2024-03-28 9:18 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28 17:50 ` Juri Linkov
2024-03-29 8:43 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 16:30 ` Juri Linkov
2024-03-30 9:36 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 18:22 ` Juri Linkov
2024-04-02 16:52 ` Juri Linkov
2024-04-04 6:16 ` Juri Linkov [this message]
2024-04-05 16:47 ` Juri Linkov
2024-04-06 18:42 ` Juri Linkov
2024-04-07 8:22 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 6:30 ` Juri Linkov
2024-04-09 7:09 ` Eli Zaretskii
2024-04-09 16:34 ` Juri Linkov
2024-04-09 18:28 ` Eli Zaretskii
2024-04-10 6:45 ` Juri Linkov
2024-04-10 8:47 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-10 11:07 ` Eli Zaretskii
2024-04-10 17:49 ` Juri Linkov
2024-04-10 18:13 ` Eli Zaretskii
2024-04-11 6:31 ` Juri Linkov
2024-04-11 7:40 ` Eli Zaretskii
2024-04-12 6:37 ` Juri Linkov
2024-04-12 7:05 ` Eli Zaretskii
2024-04-12 16:50 ` Juri Linkov
2024-04-12 18:27 ` Eli Zaretskii
2024-04-13 18:49 ` Juri Linkov
2024-04-13 19:03 ` Eli Zaretskii
2024-04-14 16:04 ` Juri Linkov
2024-04-18 14:30 ` Eli Zaretskii
2024-04-18 17:16 ` Juri Linkov
2024-04-18 17:56 ` Eli Zaretskii
2024-04-19 6:24 ` Juri Linkov
2024-04-19 6:28 ` Juri Linkov
2024-04-19 7:19 ` Eli Zaretskii
2024-04-19 16:17 ` Juri Linkov
2024-04-20 12:08 ` Eli Zaretskii
2024-04-21 6:52 ` Juri Linkov
2024-04-21 9:13 ` Eli Zaretskii
2024-04-22 6:50 ` Juri Linkov
2024-04-19 7:19 ` Eli Zaretskii
2024-04-11 9:16 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-11 11:03 ` Eli Zaretskii
2024-04-24 16:46 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wmpdu0fa.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=69983@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.