From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rudalics@gmx.at, 69983@debbugs.gnu.org
Subject: bug#69983: Use category for display-buffer-alist
Date: Fri, 19 Apr 2024 19:17:14 +0300 [thread overview]
Message-ID: <86r0f1zaed.fsf@mail.linkov.net> (raw)
In-Reply-To: <86ttjxq31i.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 19 Apr 2024 09:28:41 +0300")
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
> Sorry, actually you are right, let's add a new option.
> Will do this soon.
The reason why a new option is needed is because display-warning
doesn't move point to the bottom line with the last message.
So when the warning buffer will be displayed at the bottom of
the screen in a narrow window, but the window always stays
displaying the top of the warning buffer, the users will miss
the last unseen message.
To solve this problem, a new option 'warning-display-at-bottom'
(whose name has the same prefix as all other options in the same file)
will scroll the bottom window, so the last message will always
be visible to the user.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: warning-display-at-bottom.patch --]
[-- Type: text/x-diff, Size: 1724 bytes --]
diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el
index 8b43c6a8726..672c9ed4618 100644
--- a/lisp/emacs-lisp/warnings.el
+++ b/lisp/emacs-lisp/warnings.el
@@ -120,6 +120,14 @@ warning-suppress-types
See also `warning-suppress-log-types'."
:type '(repeat (repeat symbol))
:version "22.1")
+
+(defcustom warning-display-at-bottom t
+ "Display the warning buffer at the bottom of the screen.
+The output window will be scrolled to the bottom of the buffer
+to show the last warning message."
+ :type 'boolean
+ :version "30.1")
+
\f
;; The autoload cookie is so that programs can bind this variable
;; safely, testing the existing value, before they call one of the
@@ -362,10 +370,20 @@ display-warning
(or (< (warning-numeric-level level)
(warning-numeric-level warning-minimum-level))
(warning-suppress-p type warning-suppress-types)
- (let ((window (display-buffer buffer)))
+ (let ((window (display-buffer
+ buffer
+ (when warning-display-at-bottom
+ '(display-buffer--maybe-at-bottom
+ (window-height . (lambda (window)
+ (fit-window-to-buffer window 10)))
+ (category . warning))))))
(when (and (markerp warning-series)
(eq (marker-buffer warning-series) buffer))
(set-window-start window warning-series))
+ (when warning-display-at-bottom
+ (with-selected-window window
+ (set-window-point window (point-max))
+ (recenter -1)))
(sit-for 0)))))))))
\f
;; Use \\<special-mode-map> so that help-enable-autoload can do its thing.
next prev parent reply other threads:[~2024-04-19 16:17 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 17:19 bug#69983: Use category for display-buffer-alist Juri Linkov
2024-03-25 9:41 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-25 17:12 ` Juri Linkov
2024-03-26 9:55 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-27 7:15 ` Juri Linkov
2024-03-28 7:47 ` Juri Linkov
2024-03-28 8:23 ` Eli Zaretskii
2024-03-28 17:46 ` Juri Linkov
2024-03-28 9:18 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28 17:50 ` Juri Linkov
2024-03-29 8:43 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 16:30 ` Juri Linkov
2024-03-30 9:36 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 18:22 ` Juri Linkov
2024-04-02 16:52 ` Juri Linkov
2024-04-04 6:16 ` Juri Linkov
2024-04-05 16:47 ` Juri Linkov
2024-04-06 18:42 ` Juri Linkov
2024-04-07 8:22 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 6:30 ` Juri Linkov
2024-04-09 7:09 ` Eli Zaretskii
2024-04-09 16:34 ` Juri Linkov
2024-04-09 18:28 ` Eli Zaretskii
2024-04-10 6:45 ` Juri Linkov
2024-04-10 8:47 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-10 11:07 ` Eli Zaretskii
2024-04-10 17:49 ` Juri Linkov
2024-04-10 18:13 ` Eli Zaretskii
2024-04-11 6:31 ` Juri Linkov
2024-04-11 7:40 ` Eli Zaretskii
2024-04-12 6:37 ` Juri Linkov
2024-04-12 7:05 ` Eli Zaretskii
2024-04-12 16:50 ` Juri Linkov
2024-04-12 18:27 ` Eli Zaretskii
2024-04-13 18:49 ` Juri Linkov
2024-04-13 19:03 ` Eli Zaretskii
2024-04-14 16:04 ` Juri Linkov
2024-04-18 14:30 ` Eli Zaretskii
2024-04-18 17:16 ` Juri Linkov
2024-04-18 17:56 ` Eli Zaretskii
2024-04-19 6:24 ` Juri Linkov
2024-04-19 6:28 ` Juri Linkov
2024-04-19 7:19 ` Eli Zaretskii
2024-04-19 16:17 ` Juri Linkov [this message]
2024-04-20 12:08 ` Eli Zaretskii
2024-04-21 6:52 ` Juri Linkov
2024-04-21 9:13 ` Eli Zaretskii
2024-04-22 6:50 ` Juri Linkov
2024-04-19 7:19 ` Eli Zaretskii
2024-04-11 9:16 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-11 11:03 ` Eli Zaretskii
2024-04-24 16:46 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r0f1zaed.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=69983@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.