From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 69093@debbugs.gnu.org, juri@linkov.net
Subject: bug#69093: window-state-put doesn't update current buffer
Date: Fri, 16 Feb 2024 13:46:24 +0200 [thread overview]
Message-ID: <86r0hcvdgv.fsf@gnu.org> (raw)
In-Reply-To: <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> (bug-gnu-emacs@gnu.org)
> Cc: 69093@debbugs.gnu.org
> Date: Fri, 16 Feb 2024 10:39:36 +0100
> From: martin rudalics via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> > Thanks for explanations. I see this line in 'set-window-configuration':
> >
> > Fset_buffer (new_current_buffer);
> >
> > Do you think this is the right fix?
>
> No. I think the right fix would be to remove the above line from
> 'set-window-configuration'. We can't do that because some applications
> might depend on the current behavior. But I am quite confident that
> nobody fully understands 'set-window-configuration' anyway and can
> predict what it does when selected frame, current buffer and the buffer
> and frame stored in the CONFIGURATION argument mismatch.
A more worrisome aspect of such a change would be the gazillion uses
of save-window-excursion.
> I'd say that any code run in a state where the buffer of the selected
> window and the current buffer are not the same - regardless of whether
> this happens when a state/configuration is saved or restored - should
> simply report an error.
Some do, others don't. Still others silently correct the mismatch.
next prev parent reply other threads:[~2024-02-16 11:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 7:39 bug#69093: window-state-put doesn't update current buffer Juri Linkov
2024-02-14 9:12 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-15 7:29 ` Juri Linkov
2024-02-16 9:39 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-16 11:46 ` Eli Zaretskii [this message]
2024-02-18 7:43 ` Juri Linkov
2024-02-19 9:43 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-19 17:36 ` Drew Adams
2024-02-20 7:40 ` Juri Linkov
2024-02-21 9:04 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-21 17:27 ` Juri Linkov
2024-02-22 8:58 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-22 17:23 ` Juri Linkov
2024-02-23 8:48 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 17:32 ` Juri Linkov
2024-02-25 9:17 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 18:19 ` Juri Linkov
2024-02-26 8:42 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-04 9:40 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-05 17:14 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r0hcvdgv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69093@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.