From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 69093@debbugs.gnu.org
Subject: bug#69093: window-state-put doesn't update current buffer
Date: Thu, 15 Feb 2024 09:29:33 +0200 [thread overview]
Message-ID: <86cysy1c7e.fsf@mail.linkov.net> (raw)
In-Reply-To: <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> (martin rudalics's message of "Wed, 14 Feb 2024 10:12:04 +0100")
>> Martin, could you help to understand what is missing in
>> 'window-state-put' that it doesn't set the current buffer
>> correctly like 'set-window-configuration' does.
>
> The "current buffer" is not part of the state of a window. It is part
> of a more global state. Have a look at frameset.el which does at some
> time "Restore selected frame, buffer and point."
>
> As for what 'set-window-configuration' additionally does, have a look at
> 'current-window-configuration' where you can see that besides
>
> XSETBUFFER (data->f_current_buffer, current_buffer);
>
> it also saves the selected frame, scroll and selected windows of that
> frame's minibuffer or the frame that should receive input focus.
Thanks for explanations. I see this line in 'set-window-configuration':
Fset_buffer (new_current_buffer);
Do you think this is the right fix?
diff --git a/lisp/window.el b/lisp/window.el
index 6df20353b5e..34e6c5d4a4f 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -6498,7 +6503,8 @@ window-state-put
(when (and (window-valid-p window)
(eq (window-deletable-p window) t))
(delete-window window))))
- (window--check frame))))
+ (window--check frame)
+ (set-buffer (window-buffer)))))
(defun window-state-buffers (state)
"Return all buffers saved to the given window state STATE."
next prev parent reply other threads:[~2024-02-15 7:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 7:39 bug#69093: window-state-put doesn't update current buffer Juri Linkov
2024-02-14 9:12 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-15 7:29 ` Juri Linkov [this message]
2024-02-16 9:39 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-16 11:46 ` Eli Zaretskii
2024-02-18 7:43 ` Juri Linkov
2024-02-19 9:43 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-19 17:36 ` Drew Adams
2024-02-20 7:40 ` Juri Linkov
2024-02-21 9:04 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-21 17:27 ` Juri Linkov
2024-02-22 8:58 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-22 17:23 ` Juri Linkov
2024-02-23 8:48 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 17:32 ` Juri Linkov
2024-02-25 9:17 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 18:19 ` Juri Linkov
2024-02-26 8:42 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-04 9:40 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-05 17:14 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cysy1c7e.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=69093@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.