From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 60102@debbugs.gnu.org
Subject: bug#60102: Move gv-expander of substring to cl-lib
Date: Fri, 16 Dec 2022 09:22:10 +0200 [thread overview]
Message-ID: <86o7s3lsnx.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvv8mc4eax.fsf@iro.umontreal.ca> (Stefan Monnier via's message of "Thu, 15 Dec 2022 15:12:06 -0500")
> The `gv-expander` of `substring` uses the `cl--set-substring` function
> that's defined only in `cl-lib`, so currently, you can compile
>
> (setf (substring ...) ...)
>
> without requiring `cl-lib` but at run time it will tend to signal
> a `void-function` error.
> We could autoload `cl--set-substring`, but I think a better choice is to
> move this `gv-expander` to `cl-lib.el`.
I tried your patch by evaluating `(tab-bar-make-keymap-1)`,
but it still fails with:
Debugger entered--Lisp error: (void-function cl--set-substring)
cl--set-substring(#("*scratch* x" 0 9 ...
tab-bar-auto-width(((sep-1 menu-item " " ignore) (current-tab menu-item #("*scratch* x" 0 9 ...
tab-bar-make-keymap-1()
(progn (tab-bar-make-keymap-1))
elisp--eval-last-sexp(nil)
eval-last-sexp(nil)
funcall-interactively(eval-last-sexp nil)
command-execute(eval-last-sexp)
OTOH, autoloading `cl--set-substring` fixes this error.
next prev parent reply other threads:[~2022-12-16 7:22 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 20:12 bug#60102: Move gv-expander of substring to cl-lib Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-16 6:56 ` Eli Zaretskii
2022-12-16 14:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-04 20:00 ` Stefan Kangas
2023-09-04 20:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-16 7:22 ` Juri Linkov [this message]
2022-12-20 18:42 ` cl-lib warnings (was: bug#60102: Move gv-expander of substring to cl-lib) Stefan Monnier
2022-12-21 8:37 ` cl-lib warnings Juri Linkov
2022-12-21 12:45 ` Eli Zaretskii
2022-12-21 12:57 ` João Távora
2022-12-21 13:47 ` Eli Zaretskii
2022-12-21 14:04 ` João Távora
2022-12-21 14:20 ` Eli Zaretskii
2022-12-21 14:35 ` João Távora
2022-12-21 14:50 ` Juanma Barranquero
2022-12-21 14:55 ` João Távora
2022-12-21 14:57 ` Juanma Barranquero
2022-12-21 15:08 ` João Távora
2022-12-26 3:13 ` Milan Glacier
2022-12-26 15:10 ` João Távora
2022-12-26 23:48 ` Milan Glacier
2022-12-27 0:05 ` João Távora
2022-12-27 3:43 ` Tim Cross
2022-12-27 10:16 ` Lynn Winebarger
2022-12-27 13:00 ` Stefan Kangas
2022-12-21 17:14 ` Eli Zaretskii
2022-12-21 22:33 ` Juanma Barranquero
2022-12-22 7:13 ` Eli Zaretskii
2022-12-22 7:23 ` Juanma Barranquero
2022-12-22 8:53 ` Eli Zaretskii
2022-12-22 22:24 ` Yuan Fu
2022-12-22 23:56 ` Stefan Monnier
2022-12-23 7:30 ` Eli Zaretskii
2022-12-23 23:42 ` Yuan Fu
2022-12-24 0:24 ` Juanma Barranquero
2022-12-24 14:08 ` Stefan Monnier
2022-12-24 14:39 ` Juanma Barranquero
2022-12-24 19:13 ` Tomas Hlavaty
2022-12-24 0:26 ` João Távora
2022-12-24 10:33 ` Philip Kaludercic
2022-12-24 11:01 ` João Távora
2022-12-26 0:11 ` cl-loop and plists vs alists Philip Kaludercic
2022-12-26 0:35 ` João Távora
2022-12-26 21:06 ` Bob Rogers
2022-12-24 22:59 ` cl-lib warnings Sean Whitton
2022-12-25 1:21 ` Stefan Monnier
2022-12-25 2:39 ` package-initialize was " T.V Raman
2022-12-25 4:11 ` T.V Raman
2022-12-26 0:01 ` Stefan Monnier
2022-12-26 2:18 ` T.V Raman
2022-12-25 7:02 ` tomas
2022-12-25 9:55 ` João Távora
2022-12-25 11:33 ` tomas
2022-12-26 4:47 ` Sean Whitton
2022-12-24 6:40 ` Eli Zaretskii
2022-12-24 13:01 ` Dmitry Gutov
2023-01-06 5:40 ` Sean Whitton
2023-01-06 7:34 ` Eli Zaretskii
2023-01-06 17:58 ` Sean Whitton
2023-01-06 18:14 ` Eli Zaretskii
2023-01-06 19:03 ` Sean Whitton
2023-01-06 19:45 ` Eli Zaretskii
2022-12-21 14:15 ` Eli Zaretskii
2022-12-21 17:53 ` Stefan Monnier
2022-12-24 22:55 ` Sean Whitton
2022-12-25 7:05 ` tomas
2022-12-25 8:29 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o7s3lsnx.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=60102@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.