From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: 68799@debbugs.gnu.org, monnier@iro.umontreal.ca, jasonr@gnu.org
Subject: bug#68799: 30.0.50; emacs --fg-daemon fails silently if server-start fails
Date: Tue, 13 Feb 2024 21:46:02 +0200 [thread overview]
Message-ID: <86jzn8p2px.fsf@gnu.org> (raw)
In-Reply-To: <iermss4b5qv.fsf@janestreet.com> (message from Spencer Baugh on Tue, 13 Feb 2024 13:04:24 -0500)
> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: 68799@debbugs.gnu.org, monnier@iro.umontreal.ca, jasonr@gnu.org
> Date: Tue, 13 Feb 2024 13:04:24 -0500
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Using DAEMON_RUNNING would mean any errors while starting the server
> > will fail to show the explicit error message about that. That's a
> > regression in my book. So I hope we can find a better solution.
>
> Could you be more specific about what would regress in this situation?
> Preferably with a step by step of something that behaves worse.
I mean this error message:
(let ((dn (daemonp)))
(when dn
(when (stringp dn) (setq server-name dn))
(server-start)
(if server-process
(daemon-initialized)
(if (stringp dn)
(message
"Unable to start daemon: Emacs server named %S already running"
server-name)
(message "Unable to start the daemon.\nAnother instance of Emacs is running the server, either as daemon or interactively.\nYou can use emacsclient to connect to that Emacs process."))
(kill-emacs 1))))
> Currently the error message doesn't get shown at all, so I'm not clear
> what could be regressing.
We already established why the message doesn't show: because errors in
server-start are not caught. I thought we also agreed that catching
the errors there and letting startup.el show the above error messages
is something that should be done. I think your patch will prevent us
from doing that because the code which you suggest to patch with
DAEMON_RUNNING will kill Emacs before startup.el gets the chance to
show the error message, because daemon-initialized has not yet been
run by that time.
next prev parent reply other threads:[~2024-02-13 19:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 16:54 bug#68799: 30.0.50; emacs --fg-daemon fails silently if server-start fails Spencer Baugh
2024-01-29 17:11 ` Eli Zaretskii
2024-01-29 17:18 ` Eli Zaretskii
2024-01-29 17:32 ` Spencer Baugh
2024-01-29 17:44 ` Eli Zaretskii
2024-01-29 18:13 ` Spencer Baugh
2024-01-29 19:12 ` Eli Zaretskii
2024-01-29 20:28 ` Spencer Baugh
2024-01-30 12:08 ` Eli Zaretskii
2024-02-10 19:50 ` sbaugh
2024-02-10 20:05 ` Eli Zaretskii
2024-02-10 23:23 ` sbaugh
2024-02-11 7:24 ` Eli Zaretskii
2024-02-12 22:10 ` Spencer Baugh
2024-02-13 12:35 ` Eli Zaretskii
2024-02-13 17:37 ` Spencer Baugh
2024-02-13 17:49 ` Eli Zaretskii
2024-02-13 18:04 ` Spencer Baugh
2024-02-13 19:46 ` Eli Zaretskii [this message]
2024-02-13 20:02 ` Spencer Baugh
2024-02-13 20:04 ` Eli Zaretskii
2024-02-13 20:20 ` Spencer Baugh
2024-02-14 14:23 ` Eli Zaretskii
2024-02-14 16:11 ` Spencer Baugh
2024-02-24 9:20 ` Eli Zaretskii
2024-02-13 13:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-13 21:30 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <875xys127y.fsf@>
2024-02-14 14:35 ` Eli Zaretskii
2024-02-14 15:10 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87plwzytcg.fsf@>
2024-02-14 15:31 ` Eli Zaretskii
2024-02-14 17:40 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86jzn8p2px.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68799@debbugs.gnu.org \
--cc=jasonr@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.